----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71217/#review217356 -----------------------------------------------------------
Ship it! Ship It! - Pradeep Agrawal On Aug. 21, 2019, 7:10 a.m., Nikhil P wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71217/ > ----------------------------------------------------------- > > (Updated Aug. 21, 2019, 7:10 a.m.) > > > Review request for ranger, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, > Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and > Velmurugan Periasamy. > > > Bugs: RANGER-2535 > https://issues.apache.org/jira/browse/RANGER-2535 > > > Repository: ranger > > > Description > ------- > > Good coding practices for storing and retrieving data history in ranger > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/store/ServiceStore.java > 2af5845e2 > security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java > 113e727c4 > security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java > e7b317265 > > security-admin/src/main/java/org/apache/ranger/service/RangerDataHistService.java > 7bd0681b1 > > security-admin/src/main/java/org/apache/ranger/service/RangerPolicyLabelHelper.java > PRE-CREATION > > security-admin/src/main/java/org/apache/ranger/service/RangerPolicyLabelsService.java > 1a1b56e4c > security-admin/src/test/java/org/apache/ranger/biz/TestServiceDBStore.java > 2be371892 > > > Diff: https://reviews.apache.org/r/71217/diff/3/ > > > Testing > ------- > > 1.Tested If data is getting stored and retrieved properly in data history > table i.e. x_data_hist. > > > Thanks, > > Nikhil P > >
