----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71438/#review217590 -----------------------------------------------------------
Ship it! Ship It! - Don Bosco Durai On Sept. 5, 2019, 12:12 p.m., Kehua Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71438/ > ----------------------------------------------------------- > > (Updated Sept. 5, 2019, 12:12 p.m.) > > > Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O > hEigeartaigh, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, > Nitin Galave, pengjianhua, Pradeep Agrawal, Ramesh Mani, Selvamohan > Neethiraj, Sailaja Polavarapu, sam rome, Venkat Ranganathan, Velmurugan > Periasamy, Qiang Zhang, and Barna Zsombor Klara. > > > Bugs: RANGER-2560 > https://issues.apache.org/jira/browse/RANGER-2560 > > > Repository: ranger > > > Description > ------- > > There is one problem in the method "init()" of class "RangerSolrAuthorizer". > > Firstly, the code logic is to get the parameters "useProxyIP", > "useProxyIP","solrAppName" and "solrAppName" from RangerConfiguration, as > follows: > > useProxyIP = RangerConfiguration.getInstance().getBoolean(useProxyIP = > RangerConfiguration.getInstance().getBoolean( PROP_USE_PROXY_IP, useProxyIP); > proxyIPHeader = RangerConfiguration.getInstance().get( PROP_PROXY_IP_HEADER, > proxyIPHeader); > // First get from the -D property > solrAppName = System.getProperty("solr.kerberos.jaas.appname", solrAppName); > // Override if required from Ranger properties > solrAppName = RangerConfiguration.getInstance().get( PROP_SOLR_APP_NAME, > solrAppName); > But after that, the code logic is to call "solrPlugin.init()" to parse the > configuration file, as follows: > > configuration.addResourcesForServiceType(serviceType); > Due to the opposite logic, the values of the parameters "useProxyIP", > "useProxyIP","solrAppName" and "solrAppName" are not available. > > > Diffs > ----- > > > plugin-solr/src/main/java/org/apache/ranger/authorization/solr/authorizer/RangerSolrAuthorizer.java > f87e531 > > > Diff: https://reviews.apache.org/r/71438/diff/1/ > > > Testing > ------- > > > Thanks, > > Kehua Wu > >
