----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71352/#review217633 -----------------------------------------------------------
Ship it! Ship It! - Madhan Neethiraj On Aug. 24, 2019, 12:35 a.m., Abhay Kulkarni wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71352/ > ----------------------------------------------------------- > > (Updated Aug. 24, 2019, 12:35 a.m.) > > > Review request for ranger and Madhan Neethiraj. > > > Bugs: RANGER-2547 > https://issues.apache.org/jira/browse/RANGER-2547 > > > Repository: ranger > > > Description > ------- > > Some of the core Ranger and Authorizer classes contain static or unnecessary > class members. Good coding practices recommend minimizing use of such members. > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerAbstractContextEnricher.java > 0712bfcf7 > > agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerTagEnricher.java > fbf0360d7 > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPluginContext.java > e596b2af4 > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngineImpl.java > daa62f408 > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyRepository.java > 3a954f341 > > agents-common/src/main/java/org/apache/ranger/plugin/service/RangerAuthContext.java > 02f343196 > > agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBasePlugin.java > 8d89a187c > > agents-common/src/test/java/org/apache/ranger/plugin/policyengine/TestRangerAuthContext.java > 49dba884c > > hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java > bb015c595 > > > Diff: https://reviews.apache.org/r/71352/diff/4/ > > > Testing > ------- > > Built clean and verified that all unit tests pass. > > > Thanks, > > Abhay Kulkarni > >
