-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71484/#review217777
-----------------------------------------------------------




plugin-solr/src/main/java/org/apache/ranger/authorization/solr/authorizer/RangerSolrAuthorizer.java
Lines 119 (patched)
<https://reviews.apache.org/r/71484/#comment305161>

    Consider moving all 'info' logs towards end of this method - for easier 
readability:
    
      logger.info("RangerSolrAuthorizer.init(): authField={}, allRolesToken={}, 
enabled={}, matchType={}, qParserName={}, allowMissingValue={}, 
tokenCountField={}", authField, allRolesToken, enabled, matchMode, qParserName, 
allowMissingValue, tokenCountField);



plugin-solr/src/main/java/org/apache/ranger/authorization/solr/authorizer/RangerSolrAuthorizer.java
Lines 487 (patched)
<https://reviews.apache.org/r/71484/#comment305162>

    For easier readability, consider moving 'private' methods after public and 
protected methods.



plugin-solr/src/main/java/org/apache/ranger/authorization/solr/authorizer/RangerSolrAuthorizer.java
Lines 494 (patched)
<https://reviews.apache.org/r/71484/#comment305163>

    Consider moving all non-override methods after @Override methods.



ranger-solr-plugin-shim/src/main/java/org/apache/ranger/authorization/solr/authorizer/RangerSolrAuthorizer.java
Lines 63 (patched)
<https://reviews.apache.org/r/71484/#comment305164>

    'impl' is used only with following 'try' block. Consider moving #63 to #73.


- Madhan Neethiraj


On Sept. 16, 2019, 10:44 p.m., Sailaja Polavarapu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71484/
> -----------------------------------------------------------
> 
> (Updated Sept. 16, 2019, 10:44 p.m.)
> 
> 
> Review request for ranger, Abhay Kulkarni, Ramesh Mani, and Velmurugan 
> Periasamy.
> 
> 
> Bugs: RANGER-2393
>     https://issues.apache.org/jira/browse/RANGER-2393
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Implemented Document level authorization support for Solr based on user roles.
> 
> 
> Diffs
> -----
> 
>   
> plugin-solr/src/main/java/org/apache/ranger/authorization/solr/authorizer/RangerSolrAuthorizer.java
>  48d4fb74c 
>   
> ranger-solr-plugin-shim/src/main/java/org/apache/ranger/authorization/solr/authorizer/RangerSolrAuthorizer.java
>  4cfa7e188 
>   security-admin/src/main/java/org/apache/ranger/biz/RoleDBStore.java 
> 28b2c1108 
>   security-admin/src/main/java/org/apache/ranger/db/XXServiceDefDao.java 
> 835e5fea1 
>   security-admin/src/main/resources/META-INF/jpa_named_queries.xml 3c3d1dec1 
> 
> 
> Diff: https://reviews.apache.org/r/71484/diff/2/
> 
> 
> Testing
> -------
> 
> 1. Patched cluster with the changes and verified basic functionality is 
> working fine.
> 2. Also verified few negative cases on authorization to solr.
> 
> 
> Thanks,
> 
> Sailaja Polavarapu
> 
>

Reply via email to