----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71495/#review217819 -----------------------------------------------------------
security-admin/src/main/java/org/apache/ranger/service/RangerDataHistService.java Lines 98 (patched) <https://reviews.apache.org/r/71495/#comment305212> Consider rewriting this as: if (xXService != null) { XXServiceDef xXServiceDef = daoMgr.getXXServiceDef().getById(xXService.getType()); if (xXServiceDef != null) { policy.setServiceType(xXServiceDef.getName()); } } .... - Formatted with spaces around operators and parentheses, correct camel-case names for variables. - Defined xXServiceDef within the smallest scope where it is used. - Abhay Kulkarni On Sept. 18, 2019, 1:09 p.m., Fatima Khan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71495/ > ----------------------------------------------------------- > > (Updated Sept. 18, 2019, 1:09 p.m.) > > > Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay > Kulkarni, Madhan Neethiraj, Mehul Parikh, Ramesh Mani, Selvamohan Neethiraj, > and Velmurugan Periasamy. > > > Bugs: RANGER-2570 > https://issues.apache.org/jira/browse/RANGER-2570 > > > Repository: ranger > > > Description > ------- > > Issue on pop up of policy details of ranger access audit log row. > > > Diffs > ----- > > > security-admin/src/main/java/org/apache/ranger/service/RangerDataHistService.java > ced9ea8 > security-admin/src/main/webapp/scripts/models/RangerPolicy.js cd873b3 > > > Diff: https://reviews.apache.org/r/71495/diff/1/ > > > Testing > ------- > > The policy details get popped up. > > > Thanks, > > Fatima Khan > >
