-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71260/
-----------------------------------------------------------

(Updated Sept. 27, 2019, 6:29 a.m.)


Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, 
Madhan Neethiraj, Pradeep Agrawal, Selvamohan Neethiraj, Sailaja Polavarapu, 
and Velmurugan Periasamy.


Changes
-------

Fixed review comments.


Bugs: RANGER-2512
    https://issues.apache.org/jira/browse/RANGER-2512


Repository: ranger


Description
-------

RANGER-2512:RangerRolesRESTClient for serving user group
 roles to the plugins for evaluation


Diffs (updated)
-----

  
agents-common/src/main/java/org/apache/ranger/admin/client/AbstractRangerAdminClient.java
 6367235 
  
agents-common/src/main/java/org/apache/ranger/admin/client/RangerAdminClient.java
 b09a9be 
  
agents-common/src/main/java/org/apache/ranger/admin/client/RangerAdminRESTClient.java
 5939f38 
  
agents-common/src/main/java/org/apache/ranger/plugin/model/RangerPluginInfo.java
 e3f9f15 
  
agents-common/src/main/java/org/apache/ranger/plugin/model/RangerPolicyDelta.java
 1b69d8d 
  
agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngine.java
 d201aa6 
  
agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngineCache.java
 015ca09 
  
agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngineImpl.java
 c23a2d4 
  
agents-common/src/main/java/org/apache/ranger/plugin/service/RangerAuthContext.java
 842c58b 
  
agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBasePlugin.java
 cf833b7 
  
agents-common/src/main/java/org/apache/ranger/plugin/util/PolicyRefresher.java 
0e52c31 
  
agents-common/src/main/java/org/apache/ranger/plugin/util/RangerRESTUtils.java 
bdb77e7 
  agents-common/src/main/java/org/apache/ranger/plugin/util/RangerRoles.java 
PRE-CREATION 
  
agents-common/src/main/java/org/apache/ranger/plugin/util/RangerRolesProvider.java
 PRE-CREATION 
  
agents-common/src/main/java/org/apache/ranger/plugin/util/RangerRolesUtil.java 
PRE-CREATION 
  
agents-common/src/main/java/org/apache/ranger/plugin/util/ServicePolicies.java 
8c63434 
  
agents-common/src/test/java/org/apache/ranger/plugin/policyengine/TestPolicyEngine.java
 d0e0cfc 
  
knox-agent/src/main/java/org/apache/ranger/admin/client/RangerAdminJersey2RESTClient.java
 5dcce11 
  security-admin/db/mysql/optimized/current/ranger_core_db_mysql.sql 8e42bd9 
  
security-admin/db/mysql/patches/043-add-role-version-in-serviceVersionInfo.sql 
PRE-CREATION 
  security-admin/db/oracle/optimized/current/ranger_core_db_oracle.sql 1b158c9 
  
security-admin/db/oracle/patches/043-add-role-version-in-serviceVersionInfo.sql 
PRE-CREATION 
  security-admin/db/postgres/optimized/current/ranger_core_db_postgres.sql 
0034759 
  
security-admin/db/postgres/patches/043-add-role-version-in-serviceVersionInfo.sql
 PRE-CREATION 
  
security-admin/db/sqlanywhere/optimized/current/ranger_core_db_sqlanywhere.sql 
9dc7656 
  
security-admin/db/sqlanywhere/patches/043-add-role-version-in-serviceVersionInfo.sql
 PRE-CREATION 
  security-admin/db/sqlserver/optimized/current/ranger_core_db_sqlserver.sql 
9383d1a 
  
security-admin/db/sqlserver/patches/042-add-role-version-in-serviceVersionInfo.sql
 PRE-CREATION 
  security-admin/src/main/java/org/apache/ranger/biz/AssetMgr.java 63959c9 
  security-admin/src/main/java/org/apache/ranger/biz/RoleDBStore.java 7a67e9c 
  security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java 
92436ac 
  security-admin/src/main/java/org/apache/ranger/common/RangerRoleCache.java 
PRE-CREATION 
  security-admin/src/main/java/org/apache/ranger/db/XXGlobalStateDao.java 
f6b9e1a 
  
security-admin/src/main/java/org/apache/ranger/entity/XXServiceVersionInfo.java 
cef3863 
  security-admin/src/main/java/org/apache/ranger/rest/RoleREST.java 4af768a 
  security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java cfeaadd 
  security-admin/src/main/java/org/apache/ranger/service/RangerRoleService.java 
8857afd 


Diff: https://reviews.apache.org/r/71260/diff/7/

Changes: https://reviews.apache.org/r/71260/diff/6-7/


Testing
-------

- Testing done in Local Vm for
 1) Role cache file creation along with Policy file.
 2) Role based authorization happening based on the user / group role in the 
plugin.
 3) Ranger Admin now has role version and based on the roles are to be fetched 
to the plugin.
 4) RoleREST
curl -u user:password -H "Accept: application/json" -H "Content-Type: 
application/json" -X GET "http://`hostname 
-f`:6080/service/roles/secure/download/cm_hive?lastKnownRoleVersion=-1"


Thanks,

Ramesh Mani

Reply via email to