-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71542/
-----------------------------------------------------------

(Updated Sept. 30, 2019, 10 p.m.)


Review request for ranger, Ramesh Mani, Sailaja Polavarapu, and Velmurugan 
Periasamy.


Changes
-------

Addressed review comments


Bugs: RANGER-2510
    https://issues.apache.org/jira/browse/RANGER-2510


Repository: ranger


Description
-------

Currently, every change to any tag/service-resource/service-resource->tag 
mapping causes complete rebuilding of portions of policy-engine that map 
accessed resource to their tags. There are several disadvantages:
1. Compute time for rebuilding
2. Large traffic from ranger-admin to each of the plugins
3. Large load on JVM memory system because of frequent complete rebuilding of 
portions of policy-engine.

It will be more optimal to communicate only the changes to tags and apply them 
to existing policy-engine.


Diffs (updated)
-----

  
agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerTagEnricher.java
 306388534 
  security-admin/src/main/java/org/apache/ranger/db/XXPolicyChangeLogDao.java 
7055391d1 
  
security-admin/src/main/java/org/apache/ranger/db/XXServiceVersionInfoDao.java 
9f6f024bb 
  security-admin/src/main/java/org/apache/ranger/db/XXTagChangeLogDao.java 
ef65e9a6b 
  security-admin/src/main/java/org/apache/ranger/entity/XXPolicyChangeLog.java 
df87f70a5 
  security-admin/src/main/java/org/apache/ranger/entity/XXTagChangeLog.java 
c3eb14414 
  security-admin/src/main/java/org/apache/ranger/rest/PublicAPIsv2.java 
c33841dfd 
  
security-admin/src/main/java/org/apache/ranger/service/RangerTagDefService.java 
d4350b68e 
  security-admin/src/main/resources/META-INF/jpa_named_queries.xml 9714fa91b 
  
security-admin/src/test/java/org/apache/ranger/service/TestRangerTagDefService.java
 160a53c50 


Diff: https://reviews.apache.org/r/71542/diff/2/

Changes: https://reviews.apache.org/r/71542/diff/1-2/


Testing
-------

Developed unit tests to verify that incremental policy and tag work as expected.


Thanks,

Abhay Kulkarni

Reply via email to