----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71578/#review218057 -----------------------------------------------------------
agents-common/src/main/java/org/apache/ranger/plugin/util/RangerRESTClient.java Lines 346 (patched) <https://reviews.apache.org/r/71578/#comment305566> mTrustStoreFile => trustStoreFile agents-common/src/main/java/org/apache/ranger/plugin/util/RangerRESTClient.java Lines 629 (patched) <https://reviews.apache.org/r/71578/#comment305567> setmKeyStoreType => setKeyStoreType agents-common/src/main/java/org/apache/ranger/plugin/util/RangerRESTClient.java Lines 633 (patched) <https://reviews.apache.org/r/71578/#comment305568> setmTrustStoreType => setTrustStoreType ugsync/src/main/java/org/apache/ranger/ldapusersync/process/LdapPolicyMgrUserGroupBuilder.java Line 117 (original), 100 (patched) <https://reviews.apache.org/r/71578/#comment305569> looks like following are used only within init(); if true, please consider removing them as a instance member: - keyStoreFile - trustStoreFile - keyStoreType - trustStoreType - authenticationType - principal - keytab - Madhan Neethiraj On Oct. 3, 2019, 1:37 p.m., Mateen Mansoori wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71578/ > ----------------------------------------------------------- > > (Updated Oct. 3, 2019, 1:37 p.m.) > > > Review request for ranger, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, > Nikhil P, Pradeep Agrawal, and Velmurugan Periasamy. > > > Bugs: RANGER-2591 > https://issues.apache.org/jira/browse/RANGER-2591 > > > Repository: ranger > > > Description > ------- > > Need changes for usersync(unix/ldap) to support HA without load balancer. > - Ranger usersync should be able to sync users / groups when Ranger Admin is > in HA (even without having LB) > - User needs to define Ranger URL values in comma separated format in > 'ranger-ugsync-site.xml' config file for > 'ranger.usersync.policymanager.baseURL' name or property. > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/util/RangerRESTClient.java > ef5f1d5 > > ugsync/src/main/java/org/apache/ranger/ldapusersync/process/LdapPolicyMgrUserGroupBuilder.java > 224a600 > > ugsync/src/main/java/org/apache/ranger/unixusersync/process/PolicyMgrUserGroupBuilder.java > 52579a3 > > ugsync/src/main/java/org/apache/ranger/unixusersync/process/RangerUgSyncRESTClient.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/71578/diff/1/ > > > Testing > ------- > > ->BUILD SUCCESS > > 1.User sync verified in simple, kerberose and SSL enabled environment. > 2.Delta sync is verified for UNIX source. > 3.Authentication is verified for UNIX source and LDAP source. > 4.Checked user is able to login from both the Admin UI. > 5.Checked Authentication after changing password of UNIX user. > > > Thanks, > > Mateen Mansoori > >
