----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71583/#review218095 -----------------------------------------------------------
security-admin/src/main/java/org/apache/ranger/biz/RoleDBStore.java Lines 139 (patched) <https://reviews.apache.org/r/71583/#comment305630> The configuration variable "ranger.role.download.by.service.enabled" is read in two separate places (here and in ServiceDBStore. Please see if it can be read only at one place (in ServiceDBStore.initStore()) and returned by a public static function in ServiceDBStore class. Also consider to rename the configuration variable as "ranger.support.for.service.specific.role.download" of type boolean. - Abhay Kulkarni On Oct. 5, 2019, 1:58 a.m., Ramesh Mani wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71583/ > ----------------------------------------------------------- > > (Updated Oct. 5, 2019, 1:58 a.m.) > > > Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, > Madhan Neethiraj, Pradeep Agrawal, Selvamohan Neethiraj, Sailaja Polavarapu, > and Velmurugan Periasamy. > > > Bugs: RANGER-2512 > https://issues.apache.org/jira/browse/RANGER-2512 > > > Repository: ranger > > > Description > ------- > > RANGER-2512:RangerRolesRESTClient for serving user group roles to the plugins > for evaluation -part2 > > > Diffs > ----- > > security-admin/src/main/java/org/apache/ranger/biz/RoleDBStore.java 9151a72 > security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java > 51e08e1 > security-admin/src/main/java/org/apache/ranger/db/XXPolicyDao.java 0d46ca8 > security-admin/src/main/java/org/apache/ranger/db/XXRoleDao.java c1ec629 > > security-admin/src/main/java/org/apache/ranger/service/RangerRoleService.java > e168278 > security-admin/src/main/resources/META-INF/jpa_named_queries.xml 1a6b0bd > > > Diff: https://reviews.apache.org/r/71583/diff/1/ > > > Testing > ------- > > - Addressed review comments in preview patch. > - "ranger.role.download.by.service.enabled" introduced to enable role > download by service. By default it is "false" and it will download all the > roles when add or update of roles happens. If set to "true" only these > services which uses the roles will get the updated roles. > > > Thanks, > > Ramesh Mani > >
