----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71601/#review218209 -----------------------------------------------------------
kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStore.java Line 800 (original), 825 (patched) <https://reviews.apache.org/r/71601/#comment305784> Handle Runtime exceptions? kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStoreProvider.java Line 675 (original), 675 (patched) <https://reviews.apache.org/r/71601/#comment305783> can it be marked protected? - Velmurugan Periasamy On Oct. 11, 2019, 12:14 p.m., Dhaval Shah wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71601/ > ----------------------------------------------------------- > > (Updated Oct. 11, 2019, 12:14 p.m.) > > > Review request for ranger, Ankita Sinha, Gautam Borad, Abhay Kulkarni, Mehul > Parikh, Nikhil P, Pradeep Agrawal, Ramesh Mani, and Velmurugan Periasamy. > > > Bugs: RANGER-2537 > https://issues.apache.org/jira/browse/RANGER-2537 > > > Repository: ranger > > > Description > ------- > > Hi, > Consider below data in DB of Ranger KMS > > Key_Name Bit_Lenght Version > ezkey 128 1 > ezkey@0 128 1 > > Export keys to keystore file. > Delete keys from UI and make sure DB is empty. > Import keys from keystore file. > > Now observe the DB > > Key_Name Bit_Lenght Version > ezkey 0 0 > ezkey@0 128 1 > > > Diffs > ----- > > kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStore.java f3d7c20 > kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStoreProvider.java > 1792bc4 > > > Diff: https://reviews.apache.org/r/71601/diff/1/ > > > Testing > ------- > > After Import / export of EZ keys to / from keystore file we have tested below > scenario. > 1.) Bit lenght and version is properly updated in DB. > 2.) Successfully tested with different key size such as 128, 256. > 3.) Successfully tested Rollover operation on keys after exporting keys from > keystore file. > > > Thanks, > > Dhaval Shah > >