> On Oct. 16, 2019, 7:48 p.m., Madhan Neethiraj wrote: > > agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerTagEnricher.java > > Line 497 (original), 483 (patched) > > <https://reviews.apache.org/r/71626/diff/1/?file=2169223#file2169223line498> > > > > serviceResource might not have resourceDef.getName() - note that 'for' > > loop at #478 iterates through all resources defined in the service-def. How > > is this handled?
It is handled in RangerResourceTrie - line 163. Evaluator is added as a wildcard-evaluator if the evaluator's resource-definition is an ancestor of Trie's resource-definition. - Abhay ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71626/#review218239 ----------------------------------------------------------- On Oct. 16, 2019, 7:20 p.m., Abhay Kulkarni wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71626/ > ----------------------------------------------------------- > > (Updated Oct. 16, 2019, 7:20 p.m.) > > > Review request for ranger, Madhan Neethiraj, Ramesh Mani, and Velmurugan > Periasamy. > > > Bugs: RANGER-2510 > https://issues.apache.org/jira/browse/RANGER-2510 > > > Repository: ranger > > > Description > ------- > > Tags are not correctly propagated to descendant entity when tag-deltas are > enabled. For example, if a Hive database is tagged, then any Hive tables in > that database also should be tagged. This functionality is broken when > tag-deltas are enabled. > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerServiceResourceMatcher.java > f9bbb12b1 > > agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerTagEnricher.java > 7434ec99f > > agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerZoneResourceMatcher.java > c7f5bc4b8 > > agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerAbstractPolicyEvaluator.java > 4d6962fff > > agents-common/src/main/java/org/apache/ranger/plugin/policyresourcematcher/RangerPolicyResourceEvaluator.java > 7d43b4b8c > > agents-common/src/main/java/org/apache/ranger/plugin/util/RangerResourceTrie.java > 0cba88232 > > agents-common/src/main/java/org/apache/ranger/plugin/util/ServiceDefUtil.java > f383241f1 > > > Diff: https://reviews.apache.org/r/71626/diff/1/ > > > Testing > ------- > > Tested with a cluster to ensure that tags are propagated correctly to > descendant entities. > > > Thanks, > > Abhay Kulkarni > >
