-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71614/
-----------------------------------------------------------

(Updated Oct. 17, 2019, 4:19 p.m.)


Review request for ranger, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, 
Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and 
Velmurugan Periasamy.


Changes
-------

resolved review comments.
added rolename in descriptive message.


Bugs: RANGER-2617
    https://issues.apache.org/jira/browse/RANGER-2617


Repository: ranger


Description
-------

Scenario:
Create a role r1
Create a ranger policy for role r1
Try to delete role
Role delete is not allowed as a policy exists with the specified role.

Response: XXRole can't be deleted

Expected:
Descriptive message with details on why the operation is not allowed


Diffs (updated)
-----

  security-admin/src/main/java/org/apache/ranger/biz/RoleDBStore.java 5d432f8d8 
  security-admin/src/main/java/org/apache/ranger/db/XXPolicyRefRoleDao.java 
b92f8066f 
  security-admin/src/main/java/org/apache/ranger/db/XXRoleRefRoleDao.java 
419481079 
  security-admin/src/main/resources/META-INF/jpa_named_queries.xml 7e2139916 


Diff: https://reviews.apache.org/r/71614/diff/4/

Changes: https://reviews.apache.org/r/71614/diff/3-4/


Testing
-------

Tested on local VM if descriptive response is given If role delete is not 
allowed.


Thanks,

Nikhil P

Reply via email to