----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71651/#review218376 -----------------------------------------------------------
tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasNotificationMapper.java Line 120 (original), 121 (patched) <https://reviews.apache.org/r/71651/#comment306079> Please add "entityNotification.getIsEntityActive()" condition here as well - similar to #142: ret = entityNotification.getIsEntityActive() && ! entityNotification.getIsEmptyClassifications(); It is possible for Atlas to send entity-create/entity-update notifications for deleted entities as well - during import operation. tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasNotificationMapper.java Line 128 (original), 129 (patched) <https://reviews.apache.org/r/71651/#comment306080> Comment for #121 applies for line #129 as well. - Madhan Neethiraj On Oct. 23, 2019, 9:53 p.m., Abhay Kulkarni wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71651/ > ----------------------------------------------------------- > > (Updated Oct. 23, 2019, 9:53 p.m.) > > > Review request for ranger, Madhan Neethiraj, Sarath Subramanian, and > Velmurugan Periasamy. > > > Bugs: RANGER-2630 > https://issues.apache.org/jira/browse/RANGER-2630 > > > Repository: ranger > > > Description > ------- > > Currently, status of Atlas Entity in the delete notification received by > TagSync is ACTIVE. Because of this, current implementation of tagsync works > as expected. Tagsync should be able to handle delete operaton even if Atlas > decides to set the deleted entity's state to something other than ACTIVE. > > > Diffs > ----- > > > tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasNotificationMapper.java > a4cab28e8 > > tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/EntityNotificationWrapper.java > 9781aa646 > > > Diff: https://reviews.apache.org/r/71651/diff/5/ > > > Testing > ------- > > Passes all unit tests > > > Thanks, > > Abhay Kulkarni > >
