----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71724/#review218587 -----------------------------------------------------------
agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyRepository.java Line 821 (original), 821 (patched) <https://reviews.apache.org/r/71724/#comment306328> This change will result in policies having references to {owner} to be excluded from delegated-admin policy-engines - even if the the policy has other policy-items that don't reference {owner}. Can you please review? Also, why is it necessary to exclude such policies? - Madhan Neethiraj On Nov. 9, 2019, 7:10 a.m., Abhay Kulkarni wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71724/ > ----------------------------------------------------------- > > (Updated Nov. 9, 2019, 7:10 a.m.) > > > Review request for ranger, Madhan Neethiraj, Ramesh Mani, and Sailaja > Polavarapu. > > > Bugs: RANGER-2642 > https://issues.apache.org/jira/browse/RANGER-2642 > > > Repository: ranger > > > Description > ------- > > If Grant/Revoke REST API is invoked by a user which is not a admin or not > listed in policy.grantrevoke.auth.users config parameter value, then resource > being granted permission to should not specify ownership information. > Otherwise, such user may be able to modify a resource for which it does not > have delegated-admin privilege. > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyRepository.java > 065120f84 > security-admin/src/main/java/org/apache/ranger/biz/RangerBizUtil.java > abb1b1013 > security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java > 0ab733c65 > security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java > 3d8a32977 > > > Diff: https://reviews.apache.org/r/71724/diff/5/ > > > Testing > ------- > > Passed all unit tests > > > Thanks, > > Abhay Kulkarni > >
