----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71817/#review218792 -----------------------------------------------------------
Ship it! Ship It! - Madhan Neethiraj On Nov. 25, 2019, 9:53 p.m., Abhay Kulkarni wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71817/ > ----------------------------------------------------------- > > (Updated Nov. 25, 2019, 9:53 p.m.) > > > Review request for ranger, Madhan Neethiraj, Ramesh Mani, and Velmurugan > Periasamy. > > > Bugs: RANGER-2651 > https://issues.apache.org/jira/browse/RANGER-2651 > > > Repository: ranger > > > Description > ------- > > With large number of policies or tags, it takes a long time to initialize > plugin and evaluate access request(more than 1s). This is attributed to the > use of List data structure for maintaining evaluators for a resource in the > Trie node. > > This patch is modified from the patch submitted by the reporter of this JIRA > (star). List is replaced with Set data structure for faster initialization > and computation of common evaluators between multiple collections of > evaluators. > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerTagEnricher.java > 696399591 > > agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerSecurityZoneValidator.java > 35e3ebb91 > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/PolicyEngine.java > f7ca5e8f7 > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyRepository.java > e583fa197 > > agents-common/src/main/java/org/apache/ranger/plugin/util/RangerResourceTrie.java > cdf9f7012 > > > Diff: https://reviews.apache.org/r/71817/diff/1/ > > > Testing > ------- > > Passes all unit tests > > > Thanks, > > Abhay Kulkarni > >
