> On Dec. 12, 2019, 3:27 p.m., Madhan Neethiraj wrote: > > security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java > > Line 1638 (original), 1638 (patched) > > <https://reviews.apache.org/r/71893/diff/3/?file=2183693#file2183693line1638> > > > > Is it necessary to disallow association of KMS-service with a > > tag-service? I think not automatically linking KMS services with a > > tag-service should be good enough. Please review.
Hi Madhan, As tag service are not used for KMS so I blocked the association. However I have updated the patch with blocking only automatically linking KMS services with a tag-service - Dhaval ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71893/#review219014 ----------------------------------------------------------- On Dec. 13, 2019, 10:30 a.m., Dhaval Shah wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71893/ > ----------------------------------------------------------- > > (Updated Dec. 13, 2019, 10:30 a.m.) > > > Review request for ranger, Ankita Sinha, Gautam Borad, Abhay Kulkarni, Madhan > Neethiraj, Mehul Parikh, Nikhil P, Nitin Galave, and Pradeep Agrawal. > > > Bugs: RANGER-2668 > https://issues.apache.org/jira/browse/RANGER-2668 > > > Repository: ranger > > > Description > ------- > > Ranger KMS shouldn't be having Tag based service hence, > 1.) No Tag based service will be associated with RangerKMS default service. > > > Diffs > ----- > > security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java > f2bbd3c > > > Diff: https://reviews.apache.org/r/71893/diff/4/ > > > Testing > ------- > > 1.) Tag service is not associated with auto generated RangerKMS service and > Default service. > > > Thanks, > > Dhaval Shah > >
