-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71911/
-----------------------------------------------------------
(Updated 一月 6, 2020, 10:53 a.m.)
Review request for ranger.
Summary (updated)
-----------------
RANGER-2667 : Set controlName to allow-all when disable presto plugin
Bugs: RANGER-2667
https://issues.apache.org/jira/browse/RANGER-2667
Repository: ranger
Description
-------
Running the disable-presto-plugin.sh script will always get stuck. Because the
script sets the
controlName to an empty string and passes it to the function
addOrUpdatePropertyToFile when disable the presto plugin. If controlName is an
empty string, addOrUpdatePropertyToFile will ignore this parameter and let fn
to be the second parameter. So $3 passed to checkPropertyInFile will be empty.
In checkPropertyInFile, if the second parameter is empty, the sed command will
never return, and the disable-presto-plugin.sh script will always get stuck.
We should pass the default value of access-control.name and set controlName to
be allow-all when disable presto plugin.
The default value of access-control.name can be seen here:
https://prestodb.io/docs/current/security/built-in-system-access-control.html
Diffs
-----
agents-common/scripts/enable-agent.sh badea1898
Diff: https://reviews.apache.org/r/71911/diff/1/
Testing
-------
Thanks,
Jiayi Liu
