----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72051/#review219412 -----------------------------------------------------------
Please update XXPolicyRefDataMaskType as well, to remove audit fields (XXDBBase). - Madhan Neethiraj On Jan. 28, 2020, 7:32 a.m., Andrew Luo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72051/ > ----------------------------------------------------------- > > (Updated Jan. 28, 2020, 7:32 a.m.) > > > Review request for ranger. > > > Bugs: RANGER-2713 > https://issues.apache.org/jira/browse/RANGER-2713 > > > Repository: ranger > > > Description > ------- > > XXPolicyRef objects have fields such as create time, update time, added by > user ID, updated by user ID, but there fields are entirely useless since they > are all copied from the XXPolicy object. In addition, while improving > performance for creation of policies with large numbers of users, we > discovered that a lot of time was being spent in JPA converting these Date > objects especially. After removing these fields we saw a significant > performance improvement (a secondary benefit is less database space usage). > > > Diffs > ----- > > > security-admin/db/mysql/patches/046-drop-audit-columns-from-policy-ref-tables.sql > PRE-CREATION > > security-admin/db/oracle/patches/046-drop-audit-columns-from-policy-ref-tables.sql > PRE-CREATION > > security-admin/db/postgres/patches/046-drop-audit-columns-from-policy-ref-tables.sql > PRE-CREATION > > security-admin/db/sqlanywhere/patches/046-drop-audit-columns-from-policy-ref-tables.sql > PRE-CREATION > > security-admin/db/sqlserver/patches/046-drop-audit-columns-from-policy-ref-tables.sql > PRE-CREATION > security-admin/src/main/java/org/apache/ranger/biz/PolicyRefUpdater.java > 85e6aebc1 > > security-admin/src/main/java/org/apache/ranger/entity/XXPolicyRefAccessType.java > 6af8f99f4 > > security-admin/src/main/java/org/apache/ranger/entity/XXPolicyRefCondition.java > 4f4409d6a > security-admin/src/main/java/org/apache/ranger/entity/XXPolicyRefGroup.java > 32a1b9f24 > > security-admin/src/main/java/org/apache/ranger/entity/XXPolicyRefResource.java > 115064621 > security-admin/src/main/java/org/apache/ranger/entity/XXPolicyRefRole.java > 7aee502e0 > security-admin/src/main/java/org/apache/ranger/entity/XXPolicyRefUser.java > 8dfb92833 > security-admin/src/test/java/org/apache/ranger/biz/TestServiceDBStore.java > 69c8a4cb6 > > > Diff: https://reviews.apache.org/r/72051/diff/1/ > > > Testing > ------- > > Tested locally on Postgres and MySQL. Tested syntax of SQL on all 5 > databases. > > > Thanks, > > Andrew Luo > >
