----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71899/#review219460 -----------------------------------------------------------
agents-common/src/main/java/org/apache/ranger/plugin/store/RolePredicateUtil.java Lines 326 (patched) <https://reviews.apache.org/r/71899/#comment307631> lines #326 - #329 are not needed, as this case is covered in 'instanceof' at #332 below. Same in addPredicateForRoleHavingGroup() and addPredicateForRoleHavingUser() as well. agents-common/src/main/java/org/apache/ranger/plugin/store/RolePredicateUtil.java Lines 338 (patched) <https://reviews.apache.org/r/71899/#comment307630> containsIgnoreCase() - is this for partial match? Filter name 'ROLE_HAVING_ROLE_NAME' suggests the role should contain a role named roleName. Please review if equalsIgnoreCase() should be used. Same for #377 and #416. agents-common/src/main/java/org/apache/ranger/plugin/util/RangerRESTUtils.java Lines 69 (patched) <https://reviews.apache.org/r/71899/#comment307632> These constants are defined in SearchFilter as well. Please review and consider removing from RangerRESTUtils. - Madhan Neethiraj On Dec. 11, 2019, 12:59 a.m., Ramesh Mani wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71899/ > ----------------------------------------------------------- > > (Updated Dec. 11, 2019, 12:59 a.m.) > > > Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, > Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Selvamohan Neethiraj, > Sailaja Polavarapu, and Velmurugan Periasamy. > > > Bugs: RANGER-2640 > https://issues.apache.org/jira/browse/RANGER-2640 > > > Repository: ranger > > > Description > ------- > > RANGER-2640:Implement SHOW ROLE GRANT in Hive ranger plugin > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/admin/client/AbstractRangerAdminClient.java > 87d0190 > > agents-common/src/main/java/org/apache/ranger/admin/client/RangerAdminClient.java > 58eb00a > > agents-common/src/main/java/org/apache/ranger/admin/client/RangerAdminRESTClient.java > e5f9747 > > agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBasePlugin.java > 75fbd64 > > agents-common/src/main/java/org/apache/ranger/plugin/store/RolePredicateUtil.java > cda8d09 > > agents-common/src/main/java/org/apache/ranger/plugin/util/RangerRESTUtils.java > 0b492ab > agents-common/src/main/java/org/apache/ranger/plugin/util/SearchFilter.java > c17c63b > > hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java > a6f74b9 > > hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizerBase.java > c752489 > security-admin/src/main/java/org/apache/ranger/common/RangerSearchUtil.java > 98a8596 > security-admin/src/main/java/org/apache/ranger/rest/PublicAPIsv2.java > 1a83949 > security-admin/src/main/java/org/apache/ranger/rest/RoleREST.java 9b225a3 > > > Diff: https://reviews.apache.org/r/71899/diff/1/ > > > Testing > ------- > > - Verified in Local VM. > > > Thanks, > > Ramesh Mani > >
