----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72100/#review219533 -----------------------------------------------------------
Ship it! Ship It! - Pradeep Agrawal On Feb. 7, 2020, 3:52 p.m., Lars Francke wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72100/ > ----------------------------------------------------------- > > (Updated Feb. 7, 2020, 3:52 p.m.) > > > Review request for ranger. > > > Bugs: RANGER-2725 > https://issues.apache.org/jira/browse/RANGER-2725 > > > Repository: ranger > > > Description > ------- > > RANGER-2588 Added a basic checkstyle configuration. > > This moves the versions to newer ones (the original ones were from 2015) and > adds a bunch of rules. I went through the Sun and Google code styles as well > as the new proposed OpenJDK ones and picked a bunch of rules that make sense > to me. > > > Diffs > ----- > > dev-support/checkstyle-java-header.txt eaa97d791 > dev-support/checkstyle-suppressions.xml 0415e48f0 > dev-support/checkstyle.xml 4d7f13491 > pom.xml 0ffbb19a7 > > > Diff: https://reviews.apache.org/r/72100/diff/2/ > > > Testing > ------- > > > Thanks, > > Lars Francke > >
