[
https://issues.apache.org/jira/browse/RANGER-2725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17040134#comment-17040134
]
Lars Francke commented on RANGER-2725:
--------------------------------------
You did not know? But it's attached to _this_ Jira and you removed the rules
from it before committing. I'm afraid I'm a bit confused :)
You said:
> I have disabled the rules and have committed your change. later we can create
>separate patch for each rules and track it.
Okay. I'll put up a new PR with the same stuff as is in this Jira.
> Improve the Checkstyle integration from RANGER-2588
> ---------------------------------------------------
>
> Key: RANGER-2725
> URL: https://issues.apache.org/jira/browse/RANGER-2725
> Project: Ranger
> Issue Type: Improvement
> Components: Ranger
> Reporter: Lars Francke
> Assignee: Lars Francke
> Priority: Minor
> Attachments:
> 0001-RANGER-2725-Improve-the-Checkstyle-integration-from-.patch,
> RANGER-2725.1.patch, RANGER-2725.2.patch
>
>
> RANGER-2588 Added a basic checkstyle configuration.
> This moves the versions to newer ones (the original ones were from 2015) and
> adds a bunch of rules. I went through the Sun and Google code styles as well
> as the new proposed OpenJDK ones and picked a bunch of rules that make sense
> to me.
> I avoided adding rules that validate names of anything (e.g. classes and so
> on).
> This will generate a lot of warnings but...well...that just needs cleaning up
> :)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
