> On March 4, 2020, 3:42 p.m., Madhan Neethiraj wrote: > > agents-common/src/main/resources/service-defs/ranger-servicedef-schema-registry.json > > Lines 77 (patched) > > <https://reviews.apache.org/r/72186/diff/1/?file=2212665#file2212665line77> > > > > Are 'none-sb' and 'none-sv' real resources? Or do they represent no > > value for child resource 'schema-branch'/'schema-version'? > > > > If its later, consider marking 'schema-metadata' and 'schema-branch' > > with 'isValidLeaf=true'. Refer to ranger-servicedef-hive.json for a such > > usage. > > Volodymyr Moshkovskyi wrote: > Yes, your understanding is correct. Our case is similar to hive. I will > try to use the approach that you recommended.
@rmani The PR has been updated with the fix, can you please have another look ? - Saravanan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72186/#review219774 ----------------------------------------------------------- On March 11, 2020, 10:59 a.m., Volodymyr Moshkovskyi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72186/ > ----------------------------------------------------------- > > (Updated March 11, 2020, 10:59 a.m.) > > > Review request for ranger, Ramesh Mani and Saravanan Raju. > > > Repository: ranger > > > Description > ------- > > Ranger plugin for schema registry > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/store/EmbeddedServiceDefsUtil.java > 882ca2f > > agents-common/src/main/resources/service-defs/ranger-servicedef-schema-registry.json > PRE-CREATION > plugin-schema-registry/pom.xml PRE-CREATION > plugin-schema-registry/src/main/assembly/binary.xml PRE-CREATION > > plugin-schema-registry/src/main/java/org/apache/ranger/services/schema/registry/RangerServiceSchemaRegistry.java > PRE-CREATION > > plugin-schema-registry/src/main/java/org/apache/ranger/services/schema/registry/client/AutocompletionAgent.java > PRE-CREATION > > plugin-schema-registry/src/main/java/org/apache/ranger/services/schema/registry/client/SchemaRegistryResourceMgr.java > PRE-CREATION > > plugin-schema-registry/src/main/java/org/apache/ranger/services/schema/registry/client/connection/Client.java > PRE-CREATION > > plugin-schema-registry/src/main/java/org/apache/ranger/services/schema/registry/client/connection/SRClient.java > PRE-CREATION > > plugin-schema-registry/src/main/java/org/apache/ranger/services/schema/registry/client/connection/util/SecurityUtils.java > PRE-CREATION > > plugin-schema-registry/src/test/java/org/apache/ranger/services/schema/registry/client/AutocompletionAgentTest.java > PRE-CREATION > > plugin-schema-registry/src/test/java/org/apache/ranger/services/schema/registry/client/SchemaRegistryResourceMgrTest.java > PRE-CREATION > > plugin-schema-registry/src/test/java/org/apache/ranger/services/schema/registry/client/connection/SRClientTest.java > PRE-CREATION > > plugin-schema-registry/src/test/java/org/apache/ranger/services/schema/registry/client/connection/util/SecurityUtilsTest.java > PRE-CREATION > > plugin-schema-registry/src/test/java/org/apache/ranger/services/schema/registry/client/util/AcceptAllHostnameVerifier.java > PRE-CREATION > > plugin-schema-registry/src/test/java/org/apache/ranger/services/schema/registry/client/util/DefaultClientForTesting.java > PRE-CREATION > > plugin-schema-registry/src/test/java/org/apache/ranger/services/schema/registry/client/util/TestAutocompletionAgent.java > PRE-CREATION > plugin-schema-registry/src/test/resources/keystore.jks PRE-CREATION > plugin-schema-registry/src/test/resources/schema-text3.avcs PRE-CREATION > plugin-schema-registry/src/test/resources/ssl-schema-registry-client.yaml > PRE-CREATION > plugin-schema-registry/src/test/resources/ssl-schema-registry.yaml > PRE-CREATION > plugin-schema-registry/src/test/resources/truststore.jks PRE-CREATION > pom.xml dde449d > > > Diff: https://reviews.apache.org/r/72186/diff/1/ > > > Testing > ------- > > > Thanks, > > Volodymyr Moshkovskyi > >
