----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72261/#review220152 -----------------------------------------------------------
Ship it! Ship It! - Velmurugan Periasamy On March 24, 2020, 10:02 p.m., Sailaja Polavarapu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72261/ > ----------------------------------------------------------- > > (Updated March 24, 2020, 10:02 p.m.) > > > Review request for ranger, Abhay Kulkarni, Mehul Parikh, Mugdha Varadkar, > Ramesh Mani, and Velmurugan Periasamy. > > > Bugs: RANGER-2705 > https://issues.apache.org/jira/browse/RANGER-2705 > > > Repository: ranger > > > Description > ------- > > Made code changes for both incremental and full sync to use JNDI APIs > (LdapName and Rdn) to retrieve user/group name from the DN. Also, added few > null checks while updating user/group information to ranger admin. > > > Diffs > ----- > > > ugsync/src/main/java/org/apache/ranger/ldapusersync/process/LdapDeltaUserGroupBuilder.java > 0c54f71b3 > > ugsync/src/main/java/org/apache/ranger/ldapusersync/process/LdapPolicyMgrUserGroupBuilder.java > 31b4d3d67 > > ugsync/src/main/java/org/apache/ranger/ldapusersync/process/LdapUserGroupBuilder.java > 9563eee8d > > ugsync/src/main/java/org/apache/ranger/unixusersync/process/PolicyMgrUserGroupBuilder.java > 7402b69e3 > > ugsync/src/main/java/org/apache/ranger/unixusersync/process/UnixUserGroupBuilder.java > 2cf0082c0 > > > Diff: https://reviews.apache.org/r/72261/diff/2/ > > > Testing > ------- > > 1. Verified all the existing unit tests are run successfully. > 2. Patched a cluster with my changes and verified both with Active directory > and free IPA as the DN for users are in differnt formats. > > > Thanks, > > Sailaja Polavarapu > >
