----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72299/#review220218 -----------------------------------------------------------
Ship it! Ship It! - Abhay Kulkarni On April 3, 2020, 6:12 a.m., Dineshkumar Yadav wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72299/ > ----------------------------------------------------------- > > (Updated April 3, 2020, 6:12 a.m.) > > > Review request for ranger, Ankita Sinha, Gautam Borad, Abhay Kulkarni, Mehul > Parikh, Pradeep Agrawal, Vishal Suvagia, and Velmurugan Periasamy. > > > Repository: ranger > > > Description > ------- > > Adding the functionality of merging policy while creation of the policy. > The following conditions should match in order to merge the policy. > 1. There should be already existing policy. > 2. One should pass param mergeIfExists=true in create Policy API > 3. One should also pass param "serviceName" and "policyName". > 4. You can pass "zoneName" if available. > > > Diffs > ----- > > security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java > 8618f3279 > > > Diff: https://reviews.apache.org/r/72299/diff/1/ > > > Testing > ------- > > 1. Existing create or update policy. > 2. Creating and updating policy using postman > 3. Creating policy if already exist using below param > a) mergeIfExists=true > b) serviceName > c) policyName > expected behavior policy should get merged in existing policy. > 4. Creating policy if already exist using below param > a) updateIfExists=true > b) serviceName > c) policyName > expected behavior policy should get updated with existing policy. > 5. Creating policy if already exist using below param > a) deleteIfExists=true > b) serviceName > c) policyName > expected behavior existing policy should get deleted and new policy is > created. > > > Thanks, > > Dineshkumar Yadav > >
