-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72319/#review220230
-----------------------------------------------------------


Fix it, then Ship it!





tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasAdlsResourceMapper.java
Lines 112 (patched)
<https://reviews.apache.org/r/72319/#comment308549>

    Will this condition be ever satisfied? Please review.


- Abhay Kulkarni


On April 5, 2020, 12:51 a.m., Madhan Neethiraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72319/
> -----------------------------------------------------------
> 
> (Updated April 5, 2020, 12:51 a.m.)
> 
> 
> Review request for ranger, deepak sharma, Kishor Gollapalliwar, Abhay 
> Kulkarni, Mehul Parikh, Ramesh Mani, Sarath Subramanian, Sailaja Polavarapu, 
> and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2779
>     https://issues.apache.org/jira/browse/RANGER-2779
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> added resource-mapper to handle ADLS-Gen2 entity-types in Atlas notifications
> 
> 
> Diffs
> -----
> 
>   
> tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasAdlsResourceMapper.java
>  PRE-CREATION 
>   
> tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasResourceMapperUtil.java
>  cd2cb6304 
>   
> tagsync/src/test/java/org/apache/ranger/tagsync/process/TestAdlsResourceMapper.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/72319/diff/1/
> 
> 
> Testing
> -------
> 
> - added test cases for the new resource-mapper
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>

Reply via email to