----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72443/#review220513 -----------------------------------------------------------
Fix it, then Ship it! embeddedwebserver/src/main/java/org/apache/ranger/server/tomcat/SolrCollectionBootstrapper.java Lines 85 (patched) <https://reviews.apache.org/r/72443/#comment308984> Move #85 before #84, and set DEFAULT_SOLR_BOOTSTRP_MAX_RETRY=TRY_UNTIL_SUCCESS: private static final int TRY_UNTIL_SUCCESS = -1; public static final int DEFAULT_SOLR_BOOTSTRP_MAX_RETRY = TRY_UNTIL_SUCCESS; - Madhan Neethiraj On April 28, 2020, 6:55 a.m., Dhaval Shah wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72443/ > ----------------------------------------------------------- > > (Updated April 28, 2020, 6:55 a.m.) > > > Review request for ranger, Ankita Sinha, Gautam Borad, Jayendra Parab, Madhan > Neethiraj, Mehul Parikh, Pradeep Agrawal, and Velmurugan Periasamy. > > > Bugs: RANGER-2811 > https://issues.apache.org/jira/browse/RANGER-2811 > > > Repository: ranger > > > Description > ------- > > At present No. of attemps Ranger will make to upload configs and create > collection in Solr will be the value set to prop ranger.audit.solr.max.retry. > > By setting the value of above mentioned prop to "-1" Ranger will keep trying > to upload configs and create collection in Solr until its successfully done. > > > Diffs > ----- > > > embeddedwebserver/src/main/java/org/apache/ranger/server/tomcat/SolrCollectionBootstrapper.java > ce268fd67 > > > Diff: https://reviews.apache.org/r/72443/diff/3/ > > > Testing > ------- > > 1.) Case 1: ranger.audit.solr.max.retry = -1 > => Ranger will keep trying to upload config and create collection in solr > until its successfully done at provided time interval. > > 2.) Case 2: ranger.audit.solr.max.retry = non "-1" value > => No. of attemps will be limited as mentioned in value to upload config and > create collection in solr. > > > Thanks, > > Dhaval Shah > >
