-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72498/
-----------------------------------------------------------
Review request for ranger, Ankita Sinha, Don Bosco Durai, bhavik patel, Dhaval
Shah, Dineshkumar Yadav, Gautam Borad, Jayendra Parab, Kishor Gollapalliwar,
Abhay Kulkarni, Madhan Neethiraj, Mahesh Bandal, Mehul Parikh, Nitin Galave,
Nixon Rodrigues, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and
Velmurugan Periasamy.
Bugs: RANGER-2822
https://issues.apache.org/jira/browse/RANGER-2822
Repository: ranger
Description
-------
**Problem Statement:**
1) The embededserver module has EmbeddedServer and SolrCollectionBootstrapper
classes. both of them have their own getConfig() methods but the implementation
is same.
2) EmbeddedServer has getDecryptEncrypt() method and use that, but the same
method is available at CredentialReader class of credentialbuilder module.
3) SolrCollectionBootstrapper has two method which is not being used by any
class.
**Proposed Solution:**
1) Adding a new class EmbeddedServerUtil and config reading will be done from
there. this way EmbeddedServer and SolrCollectionBootstrapper both classes will
use EmbeddedServerUtil to read the configs.
2) use credentialbuilder module's CredentialReader class to read the
credentials from jceks.
3) Remove unused method.
**Note:** This patch does not introduce any new feature and does not fix any
existing bug. so EmbedededServer behaviour with and without this patch should
be same.
Diffs
-----
distro/src/main/assembly/admin-web.xml bae71b6db
distro/src/main/assembly/kms.xml 7b7ea8d93
embeddedwebserver/pom.xml 8574c5721
embeddedwebserver/src/main/java/org/apache/ranger/server/tomcat/EmbeddedServer.java
898b533dc
embeddedwebserver/src/main/java/org/apache/ranger/server/tomcat/EmbeddedServerUtil.java
PRE-CREATION
embeddedwebserver/src/main/java/org/apache/ranger/server/tomcat/SolrCollectionBootstrapper.java
9e2549ef5
embeddedwebserver/src/main/java/org/apache/ranger/server/tomcat/StopEmbeddedServer.java
0aedd9997
Diff: https://reviews.apache.org/r/72498/diff/1/
Testing
-------
Tested SSL enabled ranger admin with this patch.
Thanks,
Pradeep Agrawal
