----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71921/#review220719 -----------------------------------------------------------
security-admin/src/main/java/org/apache/ranger/solr/SolrAccessAuditsService.java Line 45 (original), 42 (patched) <https://reviews.apache.org/r/71921/#comment309393> remove all unused imports to avoid pmd error - Pradeep Agrawal On March 26, 2020, 2:12 a.m., Andrew Charneski wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71921/ > ----------------------------------------------------------- > > (Updated March 26, 2020, 2:12 a.m.) > > > Review request for ranger and Don Bosco Durai. > > > Repository: ranger > > > Description > ------- > > RANGER-2634 Add support for ElasticSearch as an Audit Database > > > Diffs > ----- > > agents-audit/pom.xml 8ac1edf4f65ebd9746f37b17af7906f0e3e4101d > > agents-audit/src/main/java/org/apache/ranger/audit/destination/ElasticSearchAuditDestination.java > PRE-CREATION > > agents-audit/src/main/java/org/apache/ranger/audit/provider/AuditProviderFactory.java > 88cf99b6e8e9ef5486e8101ea6fdcbdbf7d1d1b3 > hbase-agent/conf/ranger-hbase-audit-changes.cfg > 719c7cdbf16799c503d741c2fc582185f875fd02 > hbase-agent/scripts/install.properties > f4fdb14ac0e357d5cad2a67c10fe4080fc39f370 > hdfs-agent/conf/ranger-hdfs-audit-changes.cfg > e34d15451765d7eabfaa9c4e8a632e2c430be842 > hdfs-agent/scripts/install.properties > 54dc3a19ef231e5f64d247e2775e5b7729509359 > hive-agent/conf/ranger-hive-audit-changes.cfg > 3fd7e14bff93780e28bf52b97eec0ba26798ca9f > hive-agent/scripts/install.properties > 3e8f59025ae96921b86b450b03c7c11f2472198e > kms/scripts/install.properties a30b1d3a90783e79810075a577241b2c5e87035d > knox-agent/conf/ranger-knox-audit-changes.cfg > f0571e7671681f94294e9ebd4b9287a75870936c > knox-agent/scripts/install.properties > d2dbbc3fad446f8ca94143b96f986bd8617bcefb > plugin-atlas/conf/ranger-atlas-audit-changes.cfg > 07fc38279878d819bbe7f8024ed7d57c9697cd7e > plugin-atlas/conf/ranger-atlas-audit.xml > 93ad238df6e07ec24d409b389224c45956e3ac0f > plugin-atlas/scripts/install.properties > 511e6ae32afbb41acdae1af6c00f943a56eb267f > plugin-elasticsearch/conf/ranger-elasticsearch-audit-changes.cfg > 8071e7b46b54d9052264540255bf58294a419e8a > plugin-elasticsearch/scripts/install.properties > 3a5b2132ef1f00a0008d3489a5bc18718106c0a2 > plugin-kafka/conf/ranger-kafka-audit-changes.cfg > 661b498a24b95b9ba708f83b4b6c08f01c760fbd > plugin-kafka/scripts/install.properties > 6b01aedcb5c8c0090b0bf409285d240b2f713459 > plugin-kms/conf/ranger-kms-audit-changes.cfg > 69849d6a3b8213b2ff3e24034f8d680cecbd423e > plugin-kylin/conf/ranger-kylin-audit-changes.cfg > 8071e7b46b54d9052264540255bf58294a419e8a > plugin-kylin/scripts/install.properties > 126eebad0b0718be44f936b677631b18daa8f06b > plugin-ozone/conf/ranger-ozone-audit-changes.cfg > e5adb76819277a1a75dcc6c3b7e6f3c127d49f2e > plugin-ozone/scripts/install.properties > 276d192a0f29db79fbab5c57f51bcc723420a364 > plugin-presto/conf/ranger-presto-audit-changes.cfg > 661b498a24b95b9ba708f83b4b6c08f01c760fbd > plugin-presto/scripts/install.properties > 3110e2d015bd69f17fd09fc2d3b6b12b1c40fb1c > plugin-solr/conf/ranger-solr-audit-changes.cfg > 622052ed1ff45e09eb120c4889c7d1b2815f56eb > plugin-solr/scripts/install.properties > 48a9af211baef13e8fe9d0762e505a7e973d4ed9 > plugin-sqoop/conf/ranger-sqoop-audit-changes.cfg > 8071e7b46b54d9052264540255bf58294a419e8a > plugin-sqoop/scripts/install.properties > 44f16dac87ad3c9b8f431dcc5713e219422bf3bd > plugin-yarn/conf/ranger-yarn-audit-changes.cfg > 8071e7b46b54d9052264540255bf58294a419e8a > plugin-yarn/scripts/install.properties > f776c5f6fa0e05cd950b854c79a3bfd6982bd602 > pom.xml 22926fd7d04feecf308f84d98c35ce2d084591ef > > ranger-elasticsearch-plugin-shim/src/main/java/org/apache/ranger/authorization/elasticsearch/plugin/RangerElasticsearchPlugin.java > f9a683706468269bdc7936bdbcedfc357b5a04e9 > security-admin/scripts/install.properties > 155c42ccced826e73696c3c1ff7393fedc0f2159 > security-admin/scripts/ranger-admin-site-template.xml > af345cf436e8950af6a178de2f7a0559183d010b > security-admin/scripts/setup.sh 9677f57b8cde2a0b3512c858f4b625e37234138c > security-admin/scripts/upgrade_admin.py > 28b7e9884907c7e9d4f492bbfda273ac5ec5916a > security-admin/src/main/java/org/apache/ranger/AccessAuditsService.java > PRE-CREATION > security-admin/src/main/java/org/apache/ranger/biz/AssetMgr.java > 17c105f7e332b7f024fa119289edad7774bf89f8 > security-admin/src/main/java/org/apache/ranger/biz/RangerBizUtil.java > ebc72cf029ed06d6918fb8439c93a7ae3f49a333 > security-admin/src/main/java/org/apache/ranger/biz/XAuditMgr.java > 9eecc20a2a61240912570d96492824268a749f92 > > security-admin/src/main/java/org/apache/ranger/elasticsearch/ElasticSearchAccessAuditsService.java > PRE-CREATION > > security-admin/src/main/java/org/apache/ranger/elasticsearch/ElasticSearchMgr.java > PRE-CREATION > > security-admin/src/main/java/org/apache/ranger/elasticsearch/ElasticSearchUtil.java > PRE-CREATION > > security-admin/src/main/java/org/apache/ranger/solr/SolrAccessAuditsService.java > 453c7dcc8e05c4cd239bf0d7fb56e47814271524 > security-admin/src/main/resources/conf.dist/ranger-admin-site.xml > 298f02b15e5ff990c99b1f46bda49b4d64ddff81 > > security-admin/src/test/java/org/apache/ranger/elasticsearch/ElasticSearchAccessAuditsServiceTest.java > PRE-CREATION > storm-agent/conf/ranger-storm-audit-changes.cfg > 8071e7b46b54d9052264540255bf58294a419e8a > storm-agent/scripts/install.properties > e805b75fd60fda31f94a96f881bb2f984d923876 > > > Diff: https://reviews.apache.org/r/71921/diff/4/ > > > Testing > ------- > > Semi-automated tests write and then read a value from a local ElasticSearch > instance. Also set up an admin server and client running hive-plugin and > verified audit events were stored and indexed. > > > Thanks, > > Andrew Charneski > >
