----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72505/#review220759 -----------------------------------------------------------
Ship it! Ship It! - Pradeep Agrawal On May 14, 2020, 3:15 p.m., Kishor Gollapalliwar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72505/ > ----------------------------------------------------------- > > (Updated May 14, 2020, 3:15 p.m.) > > > Review request for ranger, Jayendra Parab, Abhay Kulkarni, Madhan Neethiraj, > Mehul Parikh, Pradeep Agrawal, and Velmurugan Periasamy. > > > Bugs: RANGER-2808 > https://issues.apache.org/jira/browse/RANGER-2808 > > > Repository: ranger > > > Description > ------- > > Service names must not allow space for newly created services. > > We should have backward compatibility towards services created in earlier > version using space. > > If a service is created in earlier versions with space, ranger will allow > space in name while updating such service. If a service (created in earlier > versions) is updated and removed spaces in name, next update will follow the > same validation used for newly created service. > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/errors/ValidationErrorCode.java > 14985053f > > agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerServiceValidator.java > aa8cf7e65 > > agents-common/src/test/java/org/apache/ranger/plugin/model/validation/TestRangerServiceValidator.java > 02216b65a > security-admin/src/main/webapp/scripts/modules/globalize/message/en.js > f7bd58c29 > > > Diff: https://reviews.apache.org/r/72505/diff/4/ > > > Testing > ------- > > Test Scenario: > 1. Created service without space in name > 2. Tried to create service with space in name > 3. Updated service without space in name > 4. Tried to update service by adding space in name (newly created service) > 5. Tried to update service by adding space in name (existing service without > space) > 6. Updated service by adding space in name (existing service with space) > > > Thanks, > > Kishor Gollapalliwar > >
