-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72539/
-----------------------------------------------------------
(Updated May 28, 2020, 5:12 p.m.)
Review request for ranger, Madhan Neethiraj and Velmurugan Periasamy.
Summary (updated)
-----------------
RANGER-2839: Assorted improvements for debugging and handling of thread
terminations, clean-up of unused data, etc.
Bugs: RANGER-2839
https://issues.apache.org/jira/browse/RANGER-2839
Repository: ranger
Description
-------
These are various improvements/fixes needed for issues discovered during
testing of plugins with incremental policy/delta enabled.
Highlights:
1. Threads are named for better debugging information.
2. super.join() call is made in a loop to ensure that thread is really
terminated even in the face of spurious/out-of-sync interruptions.
3. preCleanup() call ensures that clean-up happens at least and exactly once,
when incremental policy/tag feature is enabled.
Diffs
-----
agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerTagEnricher.java
5d6a4036a
agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerServiceDefHelper.java
943b3618f
agents-common/src/main/java/org/apache/ranger/plugin/policyengine/PolicyEngine.java
297d02fbb
agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngineImpl.java
b59440933
agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyRepository.java
197c30f0d
agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBasePlugin.java
236a4ab17
agents-common/src/main/java/org/apache/ranger/plugin/util/PolicyRefresher.java
63a98f2d4
security-admin/src/main/java/org/apache/ranger/biz/RangerPolicyAdminCache.java
df3c10d3f
security-admin/src/main/java/org/apache/ranger/biz/RangerPolicyAdminImpl.java
1c63e94c0
Diff: https://reviews.apache.org/r/72539/diff/2/
Testing
-------
Tested along with HDFS and Hive plugins. Works as expected and provides good
set of debugging help for tracking creation and termination of threads managed
by Ranger plugin.
Thanks,
Abhay Kulkarni
