----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72555/#review220912 -----------------------------------------------------------
security-admin/src/main/java/org/apache/ranger/biz/PolicyRefUpdater.java Lines 90 (patched) <https://reviews.apache.org/r/72555/#comment309623> Correct the indentation from here to line 100. Ensure either use space or tab throughout the patch for the indentation. avoid using mix of both. security-admin/src/main/java/org/apache/ranger/biz/PolicyRefUpdater.java Lines 390 (patched) <https://reviews.apache.org/r/72555/#comment309624> if class name is not coming in the debug logs then add that too in the log message like : LOG.debug("===> PolicyRefUpdater.groupPolicyAssociation()"); If you are planning to fix this then please make changes at other places also in this patch. security-admin/src/main/java/org/apache/ranger/biz/PolicyRefUpdater.java Lines 461 (patched) <https://reviews.apache.org/r/72555/#comment309625> check indentation from here to line 473 security-admin/src/main/java/org/apache/ranger/biz/PolicyRefUpdater.java Lines 498 (patched) <https://reviews.apache.org/r/72555/#comment309626> check indentation from here to line 503 security-admin/src/main/java/org/apache/ranger/biz/PolicyRefUpdater.java Lines 545 (patched) <https://reviews.apache.org/r/72555/#comment309627> check indentation from here to line 557 - Pradeep Agrawal On May 29, 2020, 9:18 a.m., Dineshkumar Yadav wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72555/ > ----------------------------------------------------------- > > (Updated May 29, 2020, 9:18 a.m.) > > > Review request for ranger, Ankita Sinha, Gautam Borad, Abhay Kulkarni, Mehul > Parikh, Pradeep Agrawal, Vishal Suvagia, and Velmurugan Periasamy. > > > Repository: ranger > > > Description > ------- > > When we try to create multiple policy using API having same non existing > group. Group creation is failing due to multiple thread tired to create same > group at time. > > > Diffs > ----- > > security-admin/src/main/java/org/apache/ranger/biz/PolicyRefUpdater.java > f978d5dfc > > > Diff: https://reviews.apache.org/r/72555/diff/1/ > > > Testing > ------- > > Testcase > Create multiple policy using API, different policy includes same group. > > After patch policy and non existing group created successful. > > > Thanks, > > Dineshkumar Yadav > >
