-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72578/
-----------------------------------------------------------
Review request for ranger, Ankita Sinha, Don Bosco Durai, bhavik patel, Colm O
hEigeartaigh, Gautam Borad, Jayendra Parab, Abhay Kulkarni, Madhan Neethiraj,
Mehul Parikh, Nikhil P, Nitin Galave, pengjianhua, Ramesh Mani, Selvamohan
Neethiraj, Sailaja Polavarapu, Velmurugan Periasamy, Qiang Zhang, and Zsombor
Gegesy.
Bugs: RANGER-2851
https://issues.apache.org/jira/browse/RANGER-2851
Repository: ranger
Description
-------
**Problem Statement:** When existing java file have ^M character then patch
does not get apply.
Source code in Ranger repo has several files that have CRLF endings.
With more development happening on windows there is a higher chance of more
CRLF files getting into the source code.
**Proposed Solution:**
Inspired from HADOOP-8911 and HADOOP-8912
I would like to avoid that by creating .gitattributes file which prevents
sources from having CRLF entries in text files via RANGER-2852
But before adding the .gitattributes file we need to normalize the existing
tree, so that people when they sync after .giattributes change wont end up with
a bunch of modified files in their workspace.
I am adding a couple of links here to give more primer on what exactly is the
issue and how we can try to fix it.
http://git-scm.com/docs/gitattributes#_checking_out_and_checking_in
http://stackoverflow.com/questions/170961/whats-the-best-crlf-handling-strategy-with-git
I will submit a separate RR for RANGER-2852.
**NOTE:**
1) This patch will not get apply via "git am" command however "git apply"
command will work.
2) To understand the diff reviewers has to download the patch file to check the
diff
Diffs
-----
security-admin/src/main/java/org/apache/ranger/biz/BaseMgr.java 0f5206aa8
security-admin/src/main/java/org/apache/ranger/security/context/RangerContextHolder.java
865a8491b
security-admin/src/main/java/org/apache/ranger/security/context/RangerSecurityContext.java
4f4252153
security-admin/src/main/java/org/apache/ranger/security/listener/SpringEventListener.java
8dd1d8de2
security-admin/src/main/java/org/apache/ranger/security/standalone/StandaloneSecurityHandler.java
f62f43d63
security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerUsernamePasswordAuthenticationFilter.java
62e23c021
security-admin/src/main/resources/META-INF/infinispan-cache-config.xml
7bb96ad4a
ugsync/src/main/java/org/apache/ranger/unixusersync/poc/InvalidGroupException.java
f68541eb7
ugsync/src/main/java/org/apache/ranger/unixusersync/poc/InvalidUserException.java
225523e86
ugsync/src/main/java/org/apache/ranger/unixusersync/poc/ListRangerUser.java
85af26168
ugsync/src/main/java/org/apache/ranger/unixusersync/poc/ListRangerUserGroup.java
8eb913173
ugsync/src/main/java/org/apache/ranger/unixusersync/poc/ListUserGroupTest.java
fae087026
ugsync/src/main/java/org/apache/ranger/unixusersync/poc/ListUserTest.java
fee780e42
ugsync/src/main/java/org/apache/ranger/unixusersync/poc/RangerClientUserGroupMapping.java
408e861b0
ugsync/src/main/java/org/apache/ranger/unixusersync/poc/RangerJSONParser.java
6c8205eae
ugsync/src/main/java/org/apache/ranger/unixusersync/poc/RangerUserGroupMapping.java
5aa60f01f
ugsync/src/main/java/org/apache/ranger/unixusersync/poc/RestClientPost.java
bbe9f1a68
Diff: https://reviews.apache.org/r/72578/diff/1/
Testing
-------
Build successful with this patch.
Thanks,
Pradeep Agrawal
