----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72608/#review221040 -----------------------------------------------------------
agents-audit/src/main/java/org/apache/ranger/audit/provider/MiscUtil.java Line 76 (original), 77 (patched) <https://reviews.apache.org/r/72608/#comment309822> @Abhay - you are right. There is no need to instantiate RANDOM_HOLDER. Instead, #303 should directly reference RandomHolder.random, which will defer instantiation of RandomHolder.random until its first use. agents-audit/src/main/java/org/apache/ranger/audit/provider/MiscUtil.java Lines 299 (patched) <https://reviews.apache.org/r/72608/#comment309823> SecureRandom implementation depends on various sources of entropy such as (keyboard/mouse/other i/o, ..), which makes it unpredictable. Depending upon the activities in the operating system, it might take multiple seconds to create a random number - which is not suitable for high volunme audit-log-id generation here. - Madhan Neethiraj On June 21, 2020, 9:14 p.m., Ramesh Mani wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72608/ > ----------------------------------------------------------- > > (Updated June 21, 2020, 9:14 p.m.) > > > Review request for ranger, Abhay Kulkarni and Madhan Neethiraj. > > > Bugs: RANGER-2869 > https://issues.apache.org/jira/browse/RANGER-2869 > > > Repository: ranger > > > Description > ------- > > RANGER-2869: Ranger audit module to provide an option to generate a UUID for > each audit log > > > Diffs > ----- > > agents-audit/src/main/java/org/apache/ranger/audit/provider/MiscUtil.java > b7315a9 > > agents-common/src/main/java/org/apache/ranger/plugin/audit/RangerDefaultAuditHandler.java > 137fd1f > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerAccessResult.java > b82ff29 > > > Diff: https://reviews.apache.org/r/72608/diff/1/ > > > Testing > ------- > > Verified in Local vm - Audit logs has the Strict UUID when > "xasecure.audit.auditid.strict.uuid=true", else exisiting logic of appending > the UUID with sequence is happening. > > > Thanks, > > Ramesh Mani > >
