-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72680/
-----------------------------------------------------------
Review request for ranger, Dineshkumar Yadav, Madhan Neethiraj, and Velmurugan
Periasamy.
Bugs: RANGER-2772
https://issues.apache.org/jira/browse/RANGER-2772
Repository: ranger
Description
-------
applyPolicy() semantics implies that it is equivalent to createPolicy() with
'mergeIfExists' set to value "true". However, a regression was introduced by a
patch for RANGER-2772 which violates this implication; 'mergeIfExists' is
presumed to be set to "false" by default. This leads to applyPolicy() to
implement updatePolicy() semantics when it's target is an existing policy.
Diffs
-----
agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngineImpl.java
dbdb78048
Diff: https://reviews.apache.org/r/72680/diff/1/
Testing
-------
Verified that default value of 'mergeIfExists' is set up correctly in all (two)
contexts.
1. When it is used from createPolicy(), and
2. When it is invoked through REST API.
Verified that legacy code using applyPolicy REST API is not broken.
Thanks,
Abhay Kulkarni
