----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72684/#review221269 -----------------------------------------------------------
ranger-elasticsearch-plugin-shim/src/main/java/org/apache/ranger/authorization/elasticsearch/plugin/utils/RequestUtils.java Lines 160 (patched) <https://reviews.apache.org/r/72684/#comment310144> Not mandatory but please review below suggestion if possible: may be we should use elseif and have single return statement at the end. in that case you might have to replace statements like return Arrays.asList(((GetMappingsRequest) request).indices()); with indexs = Arrays.asList(((GetMappingsRequest) request).indices()); the last statement : indexs.add("*") => can go to last else block. - Pradeep Agrawal On July 15, 2020, 9:03 a.m., ru jia wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72684/ > ----------------------------------------------------------- > > (Updated July 15, 2020, 9:03 a.m.) > > > Review request for ranger. > > > Bugs: RANGER-2911 > https://issues.apache.org/jira/browse/RANGER-2911 > > > Repository: ranger > > > Description > ------- > > Add missing impls for some ES requests to resolve that users who have right > permission will be denied. > > > Diffs > ----- > > > ranger-elasticsearch-plugin-shim/src/main/java/org/apache/ranger/authorization/elasticsearch/plugin/utils/RequestUtils.java > d07d08e > > > Diff: https://reviews.apache.org/r/72684/diff/1/ > > > Testing > ------- > > 1. Compilation ok > 2. Already used in production environment > > > Thanks, > > ru jia > >
