----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72696/#review221313 -----------------------------------------------------------
security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java Lines 2351 (patched) <https://reviews.apache.org/r/72696/#comment310196> - what is the service name in 'policies'? Wouldn't it be the name of the source-service name? If yes, wouldn't deleteExactMatchPolicyForResource() will delete the matching policies in source-service? - instead of introducing a new parameter, PARAM_POLICIES_DELETED, wouldn't it be simpler to reset PARAM_DELETE_IF_EXISTS? - Madhan Neethiraj On July 22, 2020, 3:06 p.m., Dineshkumar Yadav wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72696/ > ----------------------------------------------------------- > > (Updated July 22, 2020, 3:06 p.m.) > > > Review request for ranger, Ankita Sinha, Gautam Borad, Kishor Gollapalliwar, > Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, and > Velmurugan Periasamy. > > > Repository: ranger > > > Description > ------- > > source policy is getting deleted while importing policy with deleteifexists > parameter > > > Diffs > ----- > > security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java > 18abc2958 > > > Diff: https://reviews.apache.org/r/72696/diff/3/ > > > Testing > ------- > > Steps to Reproduce: > 1. Create 2 Hbase service i.e. hbase1 and hbase2, > 2. Create some policies in service - hbase1 > 3. perform policy import from source service - hbase1 to target service - > hbase2 > 4. Policies from service - hbase1 gets successfully imported to service - > hbase2 as per deleteifexist parameter feature > 5. After import, Policies from source service - hbase1 also gets deleted > > After patch source service is not getting deleted. > > testing is in progress. > > > Thanks, > > Dineshkumar Yadav > >
