-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72702/#review221330
-----------------------------------------------------------




security-admin/db/mysql/optimized/current/ranger_core_db_mysql.sql
Line 1316 (original), 1316 (patched)
<https://reviews.apache.org/r/72702/#comment310218>

    Can you please verify this is tested for upgrade scenarios with lot of data 
in x_ugsync_audit_info


- Velmurugan Periasamy


On July 23, 2020, 12:05 p.m., Mahesh Bandal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72702/
> -----------------------------------------------------------
> 
> (Updated July 23, 2020, 12:05 p.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Gautam Borad, Abhay Kulkarni, Madhan 
> Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, 
> and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2923
>     https://issues.apache.org/jira/browse/RANGER-2923
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Insert values for the column "sync_source_info" under table 
> "x_ugsync_audit_info" can go beyond the maximum length of column. (currently 
> limit is VARCHAR 4000).
> 
> Now changing data type to different db flavours as follows :
> 
> mysql       : VARCHAR => MEDIUMTEXT
> 
> oracle      : VARCHAR => CLOB
> 
> postgres    : VARCHAR => TEXT
> 
> sqlanywhere : VARCHAR => TEXT
> 
> sqlserver   : VARCHAR => nvarchar(max)
> 
> 
> Diffs
> -----
> 
>   security-admin/db/mysql/optimized/current/ranger_core_db_mysql.sql 
> 832d650cf 
>   
> security-admin/db/mysql/patches/048-alter-sync-source-info-in-x-ugsync-audit-info.sql
>  PRE-CREATION 
>   security-admin/db/oracle/optimized/current/ranger_core_db_oracle.sql 
> 4576e9677 
>   
> security-admin/db/oracle/patches/048-alter-sync-source-info-in-x-ugsync-audit-info.sql
>  PRE-CREATION 
>   security-admin/db/postgres/optimized/current/ranger_core_db_postgres.sql 
> 6a0941ff6 
>   
> security-admin/db/postgres/patches/048-alter-sync-source-info-in-x-ugsync-audit-info.sql
>  PRE-CREATION 
>   
> security-admin/db/sqlanywhere/optimized/current/ranger_core_db_sqlanywhere.sql
>  b663f3b02 
>   
> security-admin/db/sqlanywhere/patches/048-alter-sync-source-info-in-x-ugsync-audit-info.sql
>  PRE-CREATION 
>   security-admin/db/sqlserver/optimized/current/ranger_core_db_sqlserver.sql 
> ab370ffb1 
>   
> security-admin/db/sqlserver/patches/048-alter-sync-source-info-in-x-ugsync-audit-info.sql
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/72702/diff/1/
> 
> 
> Testing
> -------
> 
> Inserted large values of more than 4000 characters in column 
> "sync_source_info" under table "x_ugsync_audit_info". Insert query succeeds.
> 
> 
> Thanks,
> 
> Mahesh Bandal
> 
>

Reply via email to