----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72758/#review221567 -----------------------------------------------------------
Ship it! Ship It! - Madhan Neethiraj On Aug. 13, 2020, 1:17 p.m., Dineshkumar Yadav wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72758/ > ----------------------------------------------------------- > > (Updated Aug. 13, 2020, 1:17 p.m.) > > > Review request for ranger, Gautam Borad, Kishor Gollapalliwar, Abhay > Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, and Velmurugan > Periasamy. > > > Repository: ranger > > > Description > ------- > > Observed that serviceType config is currently not used while importing a > ranger policy, so we can give any random value or a different service name > [from the service name to which import should happen] > > Solution > Added validation to check for serviceType provided in import policy to it's > service. > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/errors/ValidationErrorCode.java > 971fd507b > > agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerPolicyValidator.java > fb0afbafb > > > Diff: https://reviews.apache.org/r/72758/diff/1/ > > > Testing > ------- > > serviceType is provided in import policy is validated against the service in > the policy. > > > Thanks, > > Dineshkumar Yadav > >
