----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72924/#review221990 -----------------------------------------------------------
Fix it, then Ship it! agents-common/src/main/java/org/apache/ranger/authorization/hadoop/config/RangerChainedPluginConfig.java Lines 92 (patched) <https://reviews.apache.org/r/72924/#comment311063> Consider handling this case in copyProperties() itself, in else clause at #66. - Madhan Neethiraj On Oct. 1, 2020, 9:27 p.m., Abhay Kulkarni wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72924/ > ----------------------------------------------------------- > > (Updated Oct. 1, 2020, 9:27 p.m.) > > > Review request for ranger, Madhan Neethiraj and Velmurugan Periasamy. > > > Bugs: RANGER-3020 > https://issues.apache.org/jira/browse/RANGER-3020 > > > Repository: ranger > > > Description > ------- > > Chained plugin config needs to copy selected configuration parameters from > root plugin's config and rename them to set up for proper creation and > operation of chained plugin. > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/authorization/hadoop/config/RangerChainedPluginConfig.java > 81cebf489 > > > Diff: https://reviews.apache.org/r/72924/diff/1/ > > > Testing > ------- > > Passed all unit tests > > > Thanks, > > Abhay Kulkarni > >
