----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72883/#review222020 -----------------------------------------------------------
plugin-kafka/src/main/java/org/apache/ranger/services/kafka/client/ServiceKafkaConnectionMgr.java Line 29 (original), 34 (patched) <https://reviews.apache.org/r/72883/#comment311096> Please consider having this function return an error string rather than throwing an exception. Something like: String getServiceConfigValidationErrors(Map<String, String> configs); and throw Exception with error string if return is not null. - Abhay Kulkarni On Oct. 6, 2020, 6:12 a.m., Ramesh Mani wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72883/ > ----------------------------------------------------------- > > (Updated Oct. 6, 2020, 6:12 a.m.) > > > Review request for ranger, Don Bosco Durai, Abhay Kulkarni, and Madhan > Neethiraj. > > > Bugs: RANGER-3001 > https://issues.apache.org/jira/browse/RANGER-3001 > > > Repository: ranger > > > Description > ------- > > RANGER-3001:Update Ranger KafkaClient to use Kafka AdminClient API instead of > Zookeeper > > > Diffs > ----- > > > plugin-kafka/src/main/java/org/apache/ranger/services/kafka/client/ServiceKafkaClient.java > 91a7d27dd > > plugin-kafka/src/main/java/org/apache/ranger/services/kafka/client/ServiceKafkaConnectionMgr.java > 9e0d6b4c0 > > > Diff: https://reviews.apache.org/r/72883/diff/2/ > > > Testing > ------- > > Verify in local cluster for lookup and test functionality > > - Kafka Service in Ranger has to have the following configs define for this > to work. > > bootstrap.servers = host1:9092,host2:9092,host3:9092 > security.protocol = SASL_PLAINTEXT > sasl.mechanism = GSSAPI > kafka.keytab = <keytab for kafka principal> > kafka.principal = <principal@domainname> > > > Thanks, > > Ramesh Mani > >
