----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72969/#review222245 -----------------------------------------------------------
agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngineImpl.java Lines 899 (patched) <https://reviews.apache.org/r/72969/#comment311299> return value from evaluateTagAuditPolicies() is unused. Consider replacing boolean with void. agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerAuditPolicyEvaluator.java Lines 101 (patched) <https://reviews.apache.org/r/72969/#comment311300> Consider removing this debug() if block, since the is available from #107. agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerAuditPolicyEvaluator.java Lines 267 (patched) <https://reviews.apache.org/r/72969/#comment311301> Consider handling {OWNER} as well here, similar to in RangerDefaultPolicyItemEvaluator.matchUserGroupAndOwner(): if (!ret && hasResourceOwner) { String owner = request.getResource().getOwnerUser(); ret = owner != null && user.equals(owner); } - Madhan Neethiraj On Nov. 29, 2020, 9:29 p.m., Ramesh Mani wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72969/ > ----------------------------------------------------------- > > (Updated Nov. 29, 2020, 9:29 p.m.) > > > Review request for ranger, Abhay Kulkarni, Madhan Neethiraj, and Velmurugan > Periasamy. > > > Bugs: RANGER-3000 > https://issues.apache.org/jira/browse/RANGER-3000 > > > Repository: ranger > > > Description > ------- > > RANGER-3000:Implement AuditFilters to include or exclude audit logs > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/authorization/utils/JsonUtils.java > 994d3944d > agents-common/src/main/java/org/apache/ranger/plugin/model/AuditFilter.java > PRE-CREATION > > agents-common/src/main/java/org/apache/ranger/plugin/model/RangerPolicy.java > 04c6e75c4 > > agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerServiceDefHelper.java > 0d9a346d4 > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerAccessResult.java > c54ef1704 > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngine.java > 4e41adcea > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngineImpl.java > b66d5a1ce > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyRepository.java > 169ed0f5d > > agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerAuditPolicyEvaluator.java > PRE-CREATION > > agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerDefaultPolicyEvaluator.java > 07fb63872 > > agents-common/src/main/java/org/apache/ranger/plugin/policyresourcematcher/RangerDefaultPolicyResourceMatcher.java > 979488181 > > agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBasePlugin.java > 2d9bc7382 > > agents-common/src/main/java/org/apache/ranger/plugin/util/ServicePolicies.java > 6ab068f6f > > agents-common/src/test/java/org/apache/ranger/plugin/policyengine/TestPolicyEngine.java > 63fccd0b3 > > agents-common/src/test/resources/policyengine/test_policyengine_audit_filter_hdfs.json > PRE-CREATION > > agents-common/src/test/resources/policyengine/test_policyengine_audit_filter_hive.json > PRE-CREATION > security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java > 520258715 > > > Diff: https://reviews.apache.org/r/72969/diff/3/ > > > Testing > ------- > > - Testing done in local VM. > > > Thanks, > > Ramesh Mani > >
