----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73056/#review222274 -----------------------------------------------------------
Fix it, then Ship it! security-admin/src/main/java/org/apache/ranger/db/XXServiceVersionInfoDao.java Line 139 (original), 139 (patched) <https://reviews.apache.org/r/73056/#comment311337> nit: "((" => "(" - Madhan Neethiraj On Dec. 3, 2020, 12:24 a.m., Abhay Kulkarni wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73056/ > ----------------------------------------------------------- > > (Updated Dec. 3, 2020, 12:24 a.m.) > > > Review request for ranger, Madhan Neethiraj and Ramesh Mani. > > > Bugs: RANGER-3098 > https://issues.apache.org/jira/browse/RANGER-3098 > > > Repository: ranger > > > Description > ------- > > If validity period of a tag is updated upstream, then the Ranger database is > not getting updated accordingly. Also, now, if tag is not applicable because > of expired validity period, then it is not listed in the audit record. > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerTagEnricher.java > fc7319485 > > security-admin/src/main/java/org/apache/ranger/db/XXServiceVersionInfoDao.java > b18f8f2d0 > > security-admin/src/main/java/org/apache/ranger/rest/ServiceTagsProcessor.java > 9c19bb032 > > > Diff: https://reviews.apache.org/r/73056/diff/2/ > > > Testing > ------- > > Ensured that, in a cluster, updates to validity periods are correctly shown > up in Ranger database. > > > Thanks, > > Abhay Kulkarni > >
