----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73066/#review222296 -----------------------------------------------------------
Fix it, then Ship it! hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java Lines 376 (patched) <https://reviews.apache.org/r/73066/#comment311364> For better readability, and for consistancy, I suggest moving private methods towards end of the class - after all public and protected methods. hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java Lines 390 (patched) <https://reviews.apache.org/r/73066/#comment311363> The caller doesn't seem to handle null return. Consider returning emptySet() from here, when ret is null. return ret != null ? ret : Collections.emptySet(); - Madhan Neethiraj On Dec. 5, 2020, 2:05 a.m., Ramesh Mani wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73066/ > ----------------------------------------------------------- > > (Updated Dec. 5, 2020, 2:05 a.m.) > > > Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, > Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Selvamohan Neethiraj, > Sailaja Polavarapu, and Velmurugan Periasamy. > > > Bugs: RANGER-3104 > https://issues.apache.org/jira/browse/RANGER-3104 > > > Repository: ranger > > > Description > ------- > > RANGER-3104:Ranger Hive policy with nested Roles failed to authorize request > > > Diffs > ----- > > > hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java > b909e30a8 > > > Diff: https://reviews.apache.org/r/73066/diff/2/ > > > Testing > ------- > > Testing done in local vm with nested roles and groups. > > > Thanks, > > Ramesh Mani > >
