----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73068/#review222305 -----------------------------------------------------------
Ship it! Ship It! - Madhan Neethiraj On Dec. 7, 2020, 5:32 p.m., Abhay Kulkarni wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73068/ > ----------------------------------------------------------- > > (Updated Dec. 7, 2020, 5:32 p.m.) > > > Review request for ranger and Madhan Neethiraj. > > > Bugs: RANGER-3106 > https://issues.apache.org/jira/browse/RANGER-3106 > > > Repository: ranger > > > Description > ------- > > TrieNode.undoSetup() is internally called to clean up a node in the Trie > structure. This API is invoked only when incremental updates are applied to > an existing Trie structure. > > This Jira addresses a small improvement to implementation of this API and > corresponding unit test case. > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyRepository.java > 0d6074ff4 > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerResourceTrie.java > 0ca589616 > > agents-common/src/test/java/org/apache/ranger/plugin/policyengine/TestPolicyEngine.java > 046e15f92 > > agents-common/src/test/resources/policyengine/test_policyengine_hdfs_incremental_update.json > PRE-CREATION > > > Diff: https://reviews.apache.org/r/73068/diff/2/ > > > Testing > ------- > > Passes all unit tests. > > > Thanks, > > Abhay Kulkarni > >
