----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73105/#review222382 -----------------------------------------------------------
ugsync/src/main/java/org/apache/ranger/unixusersync/process/PolicyMgrUserGroupBuilder.java Line 810 (original), 879 (patched) <https://reviews.apache.org/r/73105/#comment311435> I think it's better to use "isNotBlank" ugsync/src/main/java/org/apache/ranger/unixusersync/process/PolicyMgrUserGroupBuilder.java Lines 1661 (patched) <https://reviews.apache.org/r/73105/#comment311437> check the indentation ugsync/src/main/java/org/apache/ranger/unixusersync/process/PolicyMgrUserGroupBuilder.java Lines 1717 (patched) <https://reviews.apache.org/r/73105/#comment311436> can you create constant for "full_name", "sync_source" and "ldap_url" as it is used at multiple location - bhavik patel On Dec. 24, 2020, 12:52 a.m., Sailaja Polavarapu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73105/ > ----------------------------------------------------------- > > (Updated Dec. 24, 2020, 12:52 a.m.) > > > Review request for ranger, Abhay Kulkarni, Mehul Parikh, Ramesh Mani, and > Velmurugan Periasamy. > > > Bugs: RANGER-980 > https://issues.apache.org/jira/browse/RANGER-980 > > > Repository: ranger > > > Description > ------- > > Based on the high level design document (attached in the jira), implemented > support of deleted users/groups while sync'ng from different sync sources. > This patch includes checking users/groups that are deleted at the source, > update ranger admin, and mark them as hidden. This feature is enabled based > on the configuration and the frequency of deleted users/groups computation is > also configurable. > > > Diffs > ----- > > security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java b0d8569ac > security-admin/src/main/java/org/apache/ranger/rest/XUserREST.java > 03ccfbe67 > > ugsync-util/src/main/java/org/apache/ranger/ugsyncutil/model/XGroupInfo.java > df0426623 > ugsync-util/src/main/java/org/apache/ranger/ugsyncutil/model/XUserInfo.java > 9405a762a > > ugsync/src/main/java/org/apache/ranger/ldapusersync/process/LdapUserGroupBuilder.java > 7e5e70a3b > > ugsync/src/main/java/org/apache/ranger/unixusersync/config/UserGroupSyncConfig.java > 5d5ad58bd > > ugsync/src/main/java/org/apache/ranger/unixusersync/process/FileSourceUserGroupBuilder.java > 5f3523ebc > > ugsync/src/main/java/org/apache/ranger/unixusersync/process/PolicyMgrUserGroupBuilder.java > 556d9768e > > ugsync/src/main/java/org/apache/ranger/unixusersync/process/UnixUserGroupBuilder.java > 597cbf8c0 > ugsync/src/main/java/org/apache/ranger/usergroupsync/UserGroupSink.java > 794bc81c3 > > ugsync/src/test/java/org/apache/ranger/usergroupsync/PolicyMgrUserGroupBuilderTest.java > 5d2e62cd1 > > > Diff: https://reviews.apache.org/r/73105/diff/1/ > > > Testing > ------- > > 1. Patched cluster with the changes and verified the functionality with Unix > & AD/LDAP sysc sources. > 2. Also verified funcationality for regressions > 3. Verified all the unit tests are successful > > > Thanks, > > Sailaja Polavarapu > >
