----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73108/#review222388 -----------------------------------------------------------
agents-audit/src/main/java/org/apache/ranger/audit/destination/SolrAuditDestination.java Line 77 (original), 84 (patched) <https://reviews.apache.org/r/73108/#comment311440> PROC_SOLR_PRINCIPAL => PROP_SOLR_PRINCIPAL agents-audit/src/main/java/org/apache/ranger/audit/destination/SolrAuditDestination.java Lines 91 (patched) <https://reviews.apache.org/r/73108/#comment311441> Please add suffix _MS or _IN_MS, similar to #89 and #90. agents-audit/src/main/java/org/apache/ranger/audit/destination/SolrAuditDestination.java Line 218 (original), 127 (patched) <https://reviews.apache.org/r/73108/#comment311442> Consider moving #127 to finally block. agents-audit/src/main/java/org/apache/ranger/audit/destination/SolrAuditDestination.java Lines 191 (patched) <https://reviews.apache.org/r/73108/#comment311443> Is synchronized needed at method level, given block at #194 is synchronized? agents-audit/src/main/java/org/apache/ranger/audit/utils/KeytabConfiguration.java Lines 34 (patched) <https://reviews.apache.org/r/73108/#comment311446> Consider reusing InMemoryJAASConfiguration, instead of introducing this new classs KeytabConfiguration. - Madhan Neethiraj On Dec. 26, 2020, 9:40 p.m., Ramesh Mani wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73108/ > ----------------------------------------------------------- > > (Updated Dec. 26, 2020, 9:40 p.m.) > > > Review request for ranger, Don Bosco Durai, Abhay Kulkarni, Madhan Neethiraj, > Mehul Parikh, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan > Periasamy. > > > Bugs: RANGER-3134 > https://issues.apache.org/jira/browse/RANGER-3134 > > > Repository: ranger > > > Description > ------- > > RANGER-3134:Remove global JAAS Configuration for Ranger auditing to SOLR > > > Diffs > ----- > > > agents-audit/src/main/java/org/apache/ranger/audit/destination/SolrAuditDestination.java > cf0ba77aa > > agents-audit/src/main/java/org/apache/ranger/audit/utils/AbstractKerberosUser.java > PRE-CREATION > > agents-audit/src/main/java/org/apache/ranger/audit/utils/ConfigurationUtil.java > PRE-CREATION > > agents-audit/src/main/java/org/apache/ranger/audit/utils/KerberosAction.java > PRE-CREATION > > agents-audit/src/main/java/org/apache/ranger/audit/utils/KerberosHttpClientBuilder.java > PRE-CREATION > > agents-audit/src/main/java/org/apache/ranger/audit/utils/KerberosKeytabUser.java > PRE-CREATION > agents-audit/src/main/java/org/apache/ranger/audit/utils/KerberosUser.java > PRE-CREATION > > agents-audit/src/main/java/org/apache/ranger/audit/utils/KeytabConfiguration.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/73108/diff/1/ > > > Testing > ------- > > Verified in kerberos cluster for audit to solr for various services. > > > Thanks, > > Ramesh Mani > >
