> On Jan. 5, 2021, 5:20 a.m., Madhan Neethiraj wrote: > > Bhavik - the changes look good. > > > > This patch adds many 'excludes'; we should follow up with another patch to > > remove some of these excludes, along with fix for flagged issues. For > > example, removal of should be considered: UnnecessaryLocalBeforeReturn, > > UnnecessaryModifier, AvoidDollarSigns, UnnecessaryCast, > > IdenticalCatchBranches, ConfusingTernary, PrematureDeclaration, > > CallSuperInConstructor, ForLoopCanBeForeach, UseCollectionIsEmpty, > > UnusedLocalVariable, ForLoopVariableCount, UseTryWithResources, > > AvoidUsingHardCodedIP, DoubleCheckedLocking, NonThreadSafeSingleton
yes, that is the final goal. - bhavik ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72940/#review222403 ----------------------------------------------------------- On Jan. 5, 2021, 4:55 a.m., bhavik patel wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72940/ > ----------------------------------------------------------- > > (Updated Jan. 5, 2021, 4:55 a.m.) > > > Review request for ranger, Ankita Sinha, Dhaval Shah, Gautam Borad, Abhay > Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, > sailaja mada, and Velmurugan Periasamy. > > > Bugs: RANGER-3028 > https://issues.apache.org/jira/browse/RANGER-3028 > > > Repository: ranger > > > Description > ------- > > As a part of a good coding practice upgrade maven PMD plugin version to the > latest(3.14.0) > > > Diffs > ----- > > dev-support/ranger-pmd-ruleset.xml 65a4f1da4 > pom.xml f764ac349 > ranger-examples/dev-support/ranger-pmd-ruleset.xml 96f566a8b > security-admin/pom.xml 86e46b94b > > > Diff: https://reviews.apache.org/r/72940/diff/2/ > > > Testing > ------- > > Verified "mvn pmd:check" successful. > > > Thanks, > > bhavik patel > >
