----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73159/#review222527 -----------------------------------------------------------
hbase-agent/src/main/java/org/apache/ranger/authorization/hbase/RangerAuthorizationCoprocessor.java Lines 90 (patched) <https://reviews.apache.org/r/73159/#comment311631> There is already a static constant for '_any' in RangerPolicyEngine class. Please consider reusing it. hbase-agent/src/main/java/org/apache/ranger/authorization/hbase/RangerAuthorizationCoprocessor.java Line 1773 (original), 1787 (patched) <https://reviews.apache.org/r/73159/#comment311633> Please consider renaming this as checkGetTableInfoAccess() as this is called only for reading table names or descriptors. hbase-agent/src/test/java/org/apache/ranger/authorization/hbase/HBaseRangerAuthorizationTest.java Line 216 (original), 216 (patched) <https://reviews.apache.org/r/73159/#comment311634> This is a regression from previous behavior. Please ocnfirm with Hbase that this is desired. - Abhay Kulkarni On Jan. 25, 2021, 9:29 p.m., Ramesh Mani wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73159/ > ----------------------------------------------------------- > > (Updated Jan. 25, 2021, 9:29 p.m.) > > > Review request for ranger, Don Bosco Durai, Abhay Kulkarni, Madhan Neethiraj, > Mehul Parikh, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan > Periasamy. > > > Bugs: RANGER-3159 > https://issues.apache.org/jira/browse/RANGER-3159 > > > Repository: ranger > > > Description > ------- > > RANGER-3159: Having any permission on Hbase namespace and tables should allow > listing of namespace and tables > > > Diffs > ----- > > > hbase-agent/src/main/java/org/apache/ranger/authorization/hbase/RangerAuthorizationCoprocessor.java > 223295317 > > hbase-agent/src/test/java/org/apache/ranger/authorization/hbase/HBaseRangerAuthorizationTest.java > 524124266 > > > Diff: https://reviews.apache.org/r/73159/diff/1/ > > > Testing > ------- > > Verified following commands in local vm for authorizaton with any permission > list, list_namespace, list_namespace_tables > > > Thanks, > > Ramesh Mani > >
