-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73279/
-----------------------------------------------------------

Review request for ranger, Dhaval Shah, Dineshkumar Yadav, Gautam Borad, 
Harshal Chavan, Jayendra Parab, Kishor Gollapalliwar, Madhan Neethiraj, Mahesh 
Bandal, Mehul Parikh, Pradeep Agrawal, and Velmurugan Periasamy.


Bugs: RANGER-3239
    https://issues.apache.org/jira/browse/RANGER-3239


Repository: ranger


Description
-------

Introduce check box in service creation page on UI. Based on the checkbox, will 
decide addition/removal of audit filters at the time of service creation.

* By default checkbox will be checked and will show default audit filters in 
the audit filter section of the service creation page.
* When the user unchecked the checkbox, audit filters won't be shown on the 
screen and it will not be persisted.


Diffs
-----

  security-admin/src/main/webapp/scripts/views/service/AuditFilterConfig.js 
a190275 
  security-admin/src/main/webapp/scripts/views/service/ServiceForm.js 983f65b 
  security-admin/src/main/webapp/templates/service/ServiceForm_tmpl.html 
8666bd3 


Diff: https://reviews.apache.org/r/73279/diff/1/


Testing
-------

1.Checked when only no default filter is passed with 'toggle = true' with no 
filter the filter does not get saved
2.Checked when only 'toggle = false' the default filter should not be saved
3.Checked when default filter is present checkbox is selected
4.Checked when we remove each filter one by one the checkbox gets unselected
5.Checked during service creation checkbox is selec


Thanks,

Nitin Galave

Reply via email to