-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73303/
-----------------------------------------------------------

(Updated April 29, 2021, 9:26 p.m.)


Review request for ranger, Abhay Kulkarni, Mehul Parikh, Ramesh Mani, and 
Velmurugan Periasamy.


Changes
-------

Incorporated review comments and also added couple of unit tests.


Bugs: RANGER-3254
    https://issues.apache.org/jira/browse/RANGER-3254


Repository: ranger


Description
-------

Added additional checks before updating user or group attributes to ranger. 
Also fixed issue for not updating group memberships if same user with a 
different sync source or DN already exists in Ranger.


Diffs (updated)
-----

  ugsync-util/src/main/java/org/apache/ranger/ugsyncutil/model/XGroupInfo.java 
5f5c9aa38 
  ugsync-util/src/main/java/org/apache/ranger/ugsyncutil/model/XUserInfo.java 
058b98467 
  
ugsync/src/main/java/org/apache/ranger/unixusersync/config/UserGroupSyncConfig.java
 2271bd9aa 
  
ugsync/src/main/java/org/apache/ranger/unixusersync/process/PolicyMgrUserGroupBuilder.java
 4d8a32a8a 
  
ugsync/src/test/java/org/apache/ranger/unixusersync/process/TestFileSourceUserGroupBuilder.java
 42884afd9 
  
ugsync/src/test/java/org/apache/ranger/usergroupsync/PolicyMgrUserGroupBuilderTest.java
 4fb6b6cb8 
  ugsync/src/test/resources/usergroups-special-characters.csv PRE-CREATION 


Diff: https://reviews.apache.org/r/73303/diff/3/

Changes: https://reviews.apache.org/r/73303/diff/2-3/


Testing
-------

1. Verified all the existing unit tests pass.
2. Patched cluster and verified functionality with syncing users from unix as 
well as from AD.


Thanks,

Sailaja Polavarapu

Reply via email to